Problem/Motivation

'Back to site' button considering Block layout page (admin/structure/block/demo/bartik) as non-admin page and redirecting back to this page after content/configuration changes.

Proposed resolution

Find and fix the issue.

Steps to reproduce

  1. Install Drupal 8
  2. Go to admin->structure->block layout
  3. Click 'Demonstrate block regions (Bartik)' link. As you can see this page doesn't have 'back to site' link
  4. Go back to block page or any other admin page and click 'back to site' link

Expected result
Redirect page to home page (or non-admin page where you come from).
Actual result
Redirecting to 'block layout' page.

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#6 Screen Shot 2014-04-02 at 13.04.09.png75.48 KBvijaycs85
#4 core-js-block-admin.patch806 bytesnod_

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

As of right now, this is working "correctly".
The demo theme pages are explicitly NOT admin pages.
And "Back to site" tracks the last visited non-admin page.

If we mark the demo pages as an admin page, then the admin theme will be used, and we won't be able to demo the theme.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Regression: 'back to site' button treating 'block region demo' page as non-admin page » 'Back to site' button forgets last non-admin page after visiting 'block region demo'

I don't think this is a regression, I'd be surprised if this was not always broken.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Component: base system » toolbar.module
Issue tags: -UX +JavaScript

indeed.

(edit) next time i'll wake up before commenting.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Needs review
StatusFileSize
new core-js-block-admin.patch806 bytes

Actually it wasn't broken before. The active link patch broke it.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Title: 'Back to site' button forgets last non-admin page after visiting 'block region demo' » Regression: 'Back to site' button forgets last non-admin page after visiting 'block region demo'
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2014-04-02 at 13.04.09.png75.48 KB

Applied patch in #4 and did 'Steps to reproduce'. All looks fine now. Thanks @nod_ for the quick patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

I completely misunderstood the problem space, thanks nod_

  • Commit 633282c on 8.x by catch: 
    Issue #2230921 by nod_: Regression: 'Back to site' button forgets last...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.