Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
markup
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Mar 2014 at 10:31 UTC
Updated:
29 Jul 2014 at 23:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lewisnymanComment #2
chrisfromredfinThis is actually a fix in the field_ui base classes so this might have larger-scale implications (in a good way).
Comment #3
tompagabor commentedTested, and it works on these URL-s too:
admin/config/people/accounts/display/compact
admin/config/people/accounts/display/full
Suggestions:
1 - remove whitespace:
2229157-primary_button_types_account_forms-2.patch:12: trailing whitespace.
'#button_type' => 'primary',
2229157-primary_button_types_account_forms-2.patch:28: trailing whitespace.
'#type' => 'submit',
2 - We can add primary class to the ajax forms on the manage display pages. I atttach a screenshot about it:

Comment #4
chrisfromredfinSure! Fixed the trailing whitespace and added support for the field settings on manage display in the base class. Also updated issue summary.
Comment #5
tompagabor commentedLooks good!
Please test one more person, and if everything is OK, then go RTBC.
Comment #6
tompagabor commented4: 2229157-primary_button_types_account_forms-4.patch queued for re-testing.
Comment #7
tompagabor commentedI tested it again.
Everything is working.
Comment #8
webchickVery nice! :)
Committed and pushed to 8.x. Thanks!