Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
taxonomy.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Mar 2014 at 17:26 UTC
Updated:
29 Jul 2014 at 23:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
alexpottThe fix is check that this never called with a $vid and remove it.
Comment #2
anthonylindsay commentedtaxonomy_term_load_children is only called twice:
in
core/modules/taxonomy/lib/Drupal/taxonomy/Entity/Term.php
and
core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TermTest.php
Patch to remove the $vid from the function definition is attached.
Comment #3
alexpottLooking at the code it looks like this should be refactored to become a method on the Term storage but the patch attached addresses the bug.
Comment #4
larowlanWe have #1976298: Move taxonomy_get_tree() and associated functions to Taxonomy storage, deprecate procedural wrappers.
Comment #5
alexpottFixing title
Comment #6
webchickHm. Should we not go the other way here and fix it so limiting by $vid works? I shudder to think what this function would do no a term_data table the size of Drupal.org's, for example.
Comment #7
dawehnerIt seems quite a special feature that you have a taxonomy term (which is a content entity with a vocab as bundle) with children in different vocabularies.
Do we actually support that at all now?
Comment #8
webchickOops, turns out, no we don't. :D
Committed and pushed to 8.x. Thanks!