Problem/Motivation

When the table prefix is invalid on the Database connection page during the installation process then the error message is attached to a non exists form element.

Proposed resolution

Fix the $errors in the \Drupal\Core\Database\Install\Tasks::validateDatabaseSettings()

Remaining tasks

  1. Fix the bug.

User interface changes

No user interface changes

API changes

No API changes

How to reproduce

  1. Start to install a brand new Drupal 8 site
  2. On the Database connection page fill everything correctly except the "Table name prefix" field in the "Advanced options" fieldset.
    Fill it with a value like this: asd*+$
  3. Press the "Save and continue" button.
  4. You will see the error message, but the "Advanced options" fieldset is in the collapsed state and the "Table name prefix" field is not highlighted
CommentFileSizeAuthor
#2 Screen Shot 2014-03-30 at 12.20.38 .png49.53 KBfloretan
#1 drupal-table-prefix-error-message-2228885-01.patch1.01 KBsweetchuck

Comments

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Status: Active » Needs review
StatusFileSize
new drupal-table-prefix-error-message-2228885-01.patch1.01 KB
floretan’s picture

floretan commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2014-03-30 at 12.20.38 .png49.53 KB

The change is quite trivial (adressing the element correctly in the form array). The tests pass and manual testing confirmed both the problem and the solution.

The attached screenshot shows the correct behavior with the patch applied.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 8ebee83 and pushed to 8.x. Thanks!

  • Commit 8ebee83 on 8.x by alexpott: 
    Issue #2228885 by Sweetchuck: Error message is attached to a non exists...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.