While trying to get drush wfx ranges to work with serial numbers as part of fixing #2041221: Submission range options should be by serial number, not by SID, I discovered that ranges do not work at all, not even with SID.

After #2041221: Submission range options should be by serial number, not by SID is committed, wfx should be made to work with serial number ranges.

Comments

danchadwick’s picture

danchadwick commented
Status: Active » Fixed

This patch fixes a number of issues with 'drush wfx', including fixing range and implementing range-serial.

  1. Added new help for new option '--range-type=range-serial'. '--range-type=range' is still by range by sid.
  2. Removed unneeded / unused formal arguments and corrected block comment which implies that the drush command runs once for each batch run. It does not. It runs once and drush runs the batches in a loop.
  3. Added error checking and error message for inability to load node. This might happen when running the command in the wrong directory, for example.
  4. Corrected the parsing of the range-XXX options and their values.
  5. Added error messages for unsupported range-XXX option or invalid option value.
  6. Corrected the defaulting of the range type if 'range-type' is not specified in the command.
  7. Added default for range-latest of 100 if the range-type=latest, with message.
  8. Added default for range-start of 1 if the range-type is range or range-serial, without message.

Committed to 7.x-4.x and 8.x.

  • DanChadwick committed a0dd24b on 7.x-4.x 
    Issue #2226795 by DanChadwick: Fixed drush wfx range command do not work...
  • DanChadwick committed 05d85d2 on 8.x-4.x
    Issue #2226795 by DanChadwick: Fixed drush wfx range command do not work...
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.