Title says it all.

Consequence: e.g. the node Title field's widget at node/add/article has an "add more" wrapper. Obviously this is unneeded/unwanted.

CommentFileSizeAuthor
#11 add-more-wrapper-cardinality-2226665-10-D7.patch1.55 KBdgtlmoon
#10 2226665-d7.patch1.68 KBb_sharpe
#4 2226665-4.patch1.59 KBswentel
field_widgets_respect_single_cardinality.patch937 byteswim leers

Comments

Status: Needs review » Needs work

The last submitted patch, field_widgets_respect_single_cardinality.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Postponed

Postponed until after dev days to prevent conflicts.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
swentel’s picture

swentel commented
Status: Postponed » Needs review
StatusFileSize
new 2226665-4.patch1.59 KB

We could also just do this. This doesn't at least blow up the submission of a node and we can keep the existing structure. Should normally come back green.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Single cardinality fields get multiple cardinality widgets » Only set "add more" wrapper on fields with cardinality >1
Status: Needs review » Reviewed & tested by the community

For the sake of completeness: What I proposed in #1 is unacceptable because internally, everything is indeed handled as if it's multi-valued.

Looks completely sane to me :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.x. Thanks!

  • Commit 1e04c67 on 8.x by webchick: 
    Issue #2226665 by swentel, Wim Leers: Only set 'add more' wrapper on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jim_at_miramontes’s picture

jim_at_miramontes commented

Is there a back port of this to D7 (he asks, with a foolish degree of optimism in his voice)? The same problem seems to exist there, but it never really showed up until I started working with Bootstrap 3.x. Just checking; thanks...

b_sharpe’s picture

b_sharpe commented
StatusFileSize
new 2226665-d7.patch1.68 KB

D7 Version:

dgtlmoon’s picture

dgtlmoon commented
Version: 8.0.x-dev » 7.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new add-more-wrapper-cardinality-2226665-10-D7.patch1.55 KB

Re-rolled per current 7.x, seems to still be an issue

  • webchick committed 1e04c67 on 8.3.x 
    Issue #2226665 by swentel, Wim Leers: Only set 'add more' wrapper on...

  • webchick committed 1e04c67 on 8.3.x 
    Issue #2226665 by swentel, Wim Leers: Only set 'add more' wrapper on...

  • webchick committed 1e04c67 on 8.4.x 
    Issue #2226665 by swentel, Wim Leers: Only set 'add more' wrapper on...

  • webchick committed 1e04c67 on 8.4.x 
    Issue #2226665 by swentel, Wim Leers: Only set 'add more' wrapper on...

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.