Using CompositeFormElementTrait results in duplicating HTML ids for element and its wrapper. Currently CompositeFormElementTrait is used by #radios and #checkboxes to wrap them into a fieldset.
Potentionaly such behaviour can break js scripts that rely on element's ids.
Steps to reproduce: Create a custom form with #radios/#checkboxes or check any other form that contains any of these types.
Add --wrapper suffix to fieldset #id.
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | fix-identical-ids-op3-2226323-19.patch | 1.85 KB | kpv |
| #22 | fix-identical-ids-2226323-test_only.patch | 1.11 KB | kpv |
| #3 | fix-identical-ids-op2-2226323-3.patch | 1.31 KB | kpv |
| #3 | fix-identical-ids-op1-2226323-3.patch | 829 bytes | kpv |
Comments
Comment #1
danylevskyiComment #2
kpv commentedIt's a common issue for #radios element type with non-empty #title.
Comment #3
kpv commentedThis bug affects those element types which use
CompositeFormElementTrait, currently:radiosandcheckboxes.I've attached two patches:
template_preprocess_fieldset().Comment #4
kpv commentedComment #12
kpv commentedhere fieldset id is set directly in
CompositeFormElementTraitComment #14
kpv commentedComment #15
kpv commentedComment #16
kpv commentedComment #17
kpv commentedtypo
Comment #18
star-szrThis needs test coverage.
Comment #19
kpv commentedadded a test
Comment #20
kpv commentedComment #21
star-szr@kpv awesome, thanks. Can we get a test-only patch uploaded as well so we can see it failing without the bugfix?
Comment #22
kpv commentedComment #24
kpv commentedComment #25
star-szrCool, #19 seems pretty sensible to me.
Comment #26
alexpottNice find. Committed c2ac32c and pushed to 8.0.x. Thanks!