Rename migrate.migration.d6_profile_values.yml to migrate.migration.d6_user_profile_values.yml, just for consistency with the rest of profile migrations.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | interdiff.txt | 4.71 KB | David Hernández |
| #9 | 2225725-9.patch | 10.68 KB | David Hernández |
Comments
Comment #1
David Hernández commentedI'm on it.
Comment #2
David Hernández commentedI've renamed the yml file and all the places where is used: on the MigrateProfileValuesTest. But now I think we should update also the name of the test to match the change on the yml file: MigrateUserProfileValuesTest. Should I do that?
Comment #3
benjy commentedYes, please rename the test as well. Lets rename everything that is currently ProfileValues if we want to be consistent. Eg, the source as well.
Comment #4
David Hernández commentedOk, I already tried to rename some of the files and the tests were failing, I will try to find what's going on.
Comment #5
David Hernández commentedHere is the new patch, I renamed the source, the test and the yml. I've also updated the yml on the global migrate d6 yml and the test.
While doing this, I've noticed that we also have a ProfileField source plugin. Should I rename that one too?
Edit: sorry, I messed up the issue summary.
Comment #6
David Hernández commentedComment #7
penyaskitoYes please!
Comment #8
David Hernández commentedOn it.
Comment #9
David Hernández commentedOk, I think that's the remaining Profile code not using UserProfile.
Comment #10
benjy commentedThis needs a re-roll since the migrations were moved into the install folder. Also moving to core issue queue now the D6 migration patch is in.
Comment #11
David Hernández commentedComment #12
benjy commentedThese have already been renamed in HEAD. Not exactly what was proposed here but I think we're good.