Rename migrate.migration.d6_profile_values.yml to migrate.migration.d6_user_profile_values.yml, just for consistency with the rest of profile migrations.

Comments

David Hernández’s picture

Assigned: Unassigned » David Hernández

I'm on it.

David Hernández’s picture

Status: Active » Needs review
StatusFileSize
new2.15 KB

I've renamed the yml file and all the places where is used: on the MigrateProfileValuesTest. But now I think we should update also the name of the test to match the change on the yml file: MigrateUserProfileValuesTest. Should I do that?

benjy’s picture

Yes, please rename the test as well. Lets rename everything that is currently ProfileValues if we want to be consistent. Eg, the source as well.

David Hernández’s picture

Title: Rename migrate.migration.d6_profile_values.yml to migrate.migration.d6_user_profile_values.yml » Rename ProfileValues files to be UserProfileValues
Status: Needs review » Needs work

Ok, I already tried to rename some of the files and the tests were failing, I will try to find what's going on.

David Hernández’s picture

Assigned: David Hernández » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new5.97 KB

Here is the new patch, I renamed the source, the test and the yml. I've also updated the yml on the global migrate d6 yml and the test.

While doing this, I've noticed that we also have a ProfileField source plugin. Should I rename that one too?

Edit: sorry, I messed up the issue summary.

David Hernández’s picture

Issue summary: View changes
penyaskito’s picture

Status: Needs review » Needs work

Yes please!

David Hernández’s picture

Assigned: Unassigned » David Hernández

On it.

David Hernández’s picture

Status: Needs work » Needs review
StatusFileSize
new10.68 KB
new4.71 KB

Ok, I think that's the remaining Profile code not using UserProfile.

benjy’s picture

Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system
Status: Needs review » Needs work

This needs a re-roll since the migrations were moved into the install folder. Also moving to core issue queue now the D6 migration patch is in.

David Hernández’s picture

Issue tags: +Needs reroll
benjy’s picture

Assigned: David Hernández » Unassigned
Status: Needs work » Closed (works as designed)

These have already been renamed in HEAD. Not exactly what was proposed here but I think we're good.