When opening for example the permission page and scrolling down the permission table the sticky header has an top offset of 39 pixels.

CommentFileSizeAuthor
#7 2224625-5-after.png32.96 KBandymartha
#7 2224625-5-before.png53.62 KBandymartha
#5 2224625_permissions_sticky_header.patch668 bytesheypaxton
Screen Shot 2014-03-24 at 14.54.07.png46.32 KBoostie

Comments

sqndr’s picture

sqndr commented

It seems like the entire table is not really responsive.

sqndr’s picture

sqndr commented
Title: Wrong position sticky tableheader on mobile » Permissions table is not responsive.
Issue summary: View changes
sqndr’s picture

sqndr commented
Issue summary: View changes
sqndr’s picture

sqndr commented
Title: Permissions table is not responsive. » Wrong position sticky tableheader on mobile
Issue summary: View changes
heypaxton’s picture

heypaxton commented
StatusFileSize
new 2224625_permissions_sticky_header.patch668 bytes

I fixed the positioning on the sticky header. It now sits nicely at the top of the screen when scrolling.

mikeker’s picture

mikeker commented
Status: Active » Needs review

My quick testing shows #5 fixes the sticky header issue. Setting to NR to see what the testbot thinks...

andymartha’s picture

andymartha commented
StatusFileSize
new 2224625-5-before.png53.62 KB
new 2224625-5-after.png32.96 KB

Hi, thanks for the patch heypaxton.
After applying 2224625_permissions_sticky_header.patch in #5, the gap seems to have disappeared on my Android phone and Google Chrome's mobile/user-agent emulators. See screenshots.

andymartha’s picture

andymartha commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 3b6d1be on 8.0.x 
    Issue #2224625 by heypaxton: Fixed Wrong position sticky tableheader on...
heypaxton’s picture

heypaxton commented

Glad I could help. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.