Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'm dealing with data through feeds where fields are base64 encoded. I figured it would be a nice addition to the default plugins and it's an easy implementation. Needs review, works good locally.
Comment | File | Size | Author |
---|---|---|---|
#8 | feeds_tamper-add_encoder_decoder-2224595-8.patch | 2.97 KB | thePanz |
|
Comments
Comment #1
twistor CreditAttribution: twistor commentedhmmm... :)
This looks good. Just needs a couple tests.
Comment #2
kamescg CreditAttribution: kamescg commentedEDIT - Irrelevant comment
Comment #3
thePanz CreditAttribution: thePanz at Liip for FREITAG lab. AG commentedThis patch adds a Plugin with set of encoders/decoders; the following modes are available:
- serializa/unserialize from PHP
- base64_encode/base64_decode
- json_encode/json_decode
Preliminary tests have been added, too.
Comment #5
thePanz CreditAttribution: thePanz at Liip for FREITAG lab. AG commentedRemoved unused _validate callback.
Comment #6
thePanz CreditAttribution: thePanz at Liip for FREITAG lab. AG commentedComment #8
thePanz CreditAttribution: thePanz at Liip for FREITAG lab. AG commentedUpdated patch
Comment #9
sher1 CreditAttribution: sher1 as a volunteer commentedI patched my feeds_tamper with this patch (great idea by the way) but the new encode/decode options aren't showing up in the plugin list. The file is there in the plugins directory but I can't use it.
Comment #10
thePanz CreditAttribution: thePanz at Liip for FREITAG lab. AG commented@sher1: did you already try to clear the Drupal cache and/or the Drupal registry?
Comment #11
sher1 CreditAttribution: sher1 as a volunteer commentedThe key is to check to see which copy of feeds_tamper you are using. I had patched the one in sites/all/modules and not the local copy that my site was using. It shows up just fine. Sorry for the false alarm.
Comment #12
thePanz CreditAttribution: thePanz at Liip for FREITAG lab. AG commentedNo problem @sher1! :) Feel free to update the status of this issue to "Review & Tested by the community" if it is working for you, thanks!
Comment #13
Watergate CreditAttribution: Watergate at Sicse commentedThanks for the patch and I can confirm that the base64 decoding works. I've looked at the code and this seems fine to me. Marking this as RTBC.
Comment #15
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedLooks good to me too. I made a few changes in the code comments on commit.