I'm dealing with data through feeds where fields are base64 encoded. I figured it would be a nice addition to the default plugins and it's an easy implementation. Needs review, works good locally.

CommentFileSizeAuthor
#8 feeds_tamper-add_encoder_decoder-2224595-8.patch2.97 KBthepanz
#5 feeds_tamper-add_encoder_decoder-2224595-5.patch2.97 KBthepanz
#3 feeds_tamper-add_encoder_decoder-2224595-3.patch3.05 KBthepanz
feeds_tamper-base64.patch1.19 KBblazindrop

Comments

twistor’s picture

twistor commented
Status: Needs review » Needs work
Issue tags: +Needs tests 
+++ b/docroot/sites/all/modules/contrib/feeds_tamper/plugins/base64.inc
@@ -0,0 +1,36 @@
+ * Convert text to upper, lower, or title case.

hmmm... :)

This looks good. Just needs a couple tests.

kamescg’s picture

kamescg commented

EDIT - Irrelevant comment

thepanz’s picture

thepanz commented
Title: Base64 encoding/decoding plugin » Encoding/decoding plugin
Status: Needs work » Needs review
StatusFileSize
new feeds_tamper-add_encoder_decoder-2224595-3.patch3.05 KB

This patch adds a Plugin with set of encoders/decoders; the following modes are available:

- serializa/unserialize from PHP
- base64_encode/base64_decode
- json_encode/json_decode

Preliminary tests have been added, too.

Status: Needs review » Needs work

The last submitted patch, 3: feeds_tamper-add_encoder_decoder-2224595-3.patch, failed testing.

thepanz’s picture

thepanz commented
StatusFileSize
new feeds_tamper-add_encoder_decoder-2224595-5.patch2.97 KB

Removed unused _validate callback.

thepanz’s picture

thepanz commented
Assigned: blazindrop » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: feeds_tamper-add_encoder_decoder-2224595-5.patch, failed testing.

thepanz’s picture

thepanz commented
Status: Needs work » Needs review
StatusFileSize
new feeds_tamper-add_encoder_decoder-2224595-8.patch2.97 KB

Updated patch

sher1’s picture

sher1 commented

I patched my feeds_tamper with this patch (great idea by the way) but the new encode/decode options aren't showing up in the plugin list. The file is there in the plugins directory but I can't use it.

thepanz’s picture

thepanz commented

@sher1: did you already try to clear the Drupal cache and/or the Drupal registry?

sher1’s picture

sher1 commented

The key is to check to see which copy of feeds_tamper you are using. I had patched the one in sites/all/modules and not the local copy that my site was using. It shows up just fine. Sorry for the false alarm.

thepanz’s picture

thepanz commented

No problem @sher1! :) Feel free to update the status of this issue to "Review & Tested by the community" if it is working for you, thanks!

watergate’s picture

watergate commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch and I can confirm that the base64 decoding works. I've looked at the code and this seems fine to me. Marking this as RTBC.

  • MegaChriz committed 2058693 on 7.x-1.x authored by thePanz 
    Issue #2224595 by thePanz, blazindrop, Watergate, MegaChriz: Added...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Looks good to me too. I made a few changes in the code comments on commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.