We should define a separate permission 'administer twitter' which will allow users with this permission to configure the settings.

CommentFileSizeAuthor
#8 twitter-n2222837-7-6.x-5.x.patch3.18 KBdamienmckenna
#6 twitter-n2222837-6-7.x-6.x.patch2.84 KBdamienmckenna
#5 twitter-n2222837-5-7.x-5.x.patch3.41 KBdamienmckenna
#1 twitter-administer-twitter-settings-permission-2222837-1.patch1.07 KBrahulbile

Comments

rahulbile’s picture

rahulbile commented
Issue summary: View changes
StatusFileSize
new twitter-administer-twitter-settings-permission-2222837-1.patch1.07 KB

Attached is the patch against 7.x-5.x

rahulbile’s picture

rahulbile commented
Assigned: rahulbile » Unassigned
Status: Active » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Triggering the testbot.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Triggering the testbot.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new twitter-n2222837-5-7.x-5.x.patch3.41 KB

This version updates the submodules to use the new permission, and adds an update script to add the permission to any users that had "administer site configuration".

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 7.x-6.x-dev
StatusFileSize
new twitter-n2222837-6-7.x-6.x.patch2.84 KB

Ported to 7.x-6.x.

Status: Needs review » Needs work

The last submitted patch, 6: twitter-n2222837-6-7.x-6.x.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 6.x-5.x-dev
Status: Needs work » Needs review
StatusFileSize
new twitter-n2222837-7-6.x-5.x.patch3.18 KB

Ported to 6.x-5.x.

  • DamienMcKenna committed 6c23a45 on 7.x-5.x 
    Issue #2222837 by rahulbile, DamienMcKenna: New permission for...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 0ed5f28 on 6.x-5.x 
    Issue #2222837 by rahulbile, DamienMcKenna: New permission for...

  • DamienMcKenna committed f213435 on 7.x-6.x 
    Issue #2222837 by rahulbile, DamienMcKenna: New permission for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.