Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
20 Mar 2014 at 13:33 UTC
Updated:
29 Jul 2014 at 23:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
benjy commentedI think we should make the default to skip row instead of the fatal error. This also saves us having an extra configuration option.
Comment #2
David Hernández commentedI'm not really sure, but I think this is what is needed to skip rows by default.
Comment #3
rvilarIt works for me. I'm using it for a use case in my migration on #2225293: Migrate D6 and D7 language negotiation settings
Comment #4
pcambraLooks good to me
Comment #5
benjy commentedWe no longer need the sprintf() since the message isn't used anywhere.
Also, moving this into the core issue queue since it's a change in the migrate module which i'm trying to avoid in the sandbox unless it is specifically holding something up.
Comment #6
David Hernández commentedOk, fixing it. But this patch is required for #2225293
Comment #7
pcambraComment #8
David Hernández commentedComment #9
benjy commentedLooks good. This is an API change for the default behaviour for migrations using the static map so we'll need to re-run all the tests in the sandbox too.
Comment #11
berdir8: 2222169-8.patch queued for re-testing.
Comment #12
benjy commentedBack to RTBC.
Comment #13
alexpottCommitted c1cf341 and pushed to 8.x. Thanks!