Remove uses of deprecated URL functions

Some of these still need to be marked @deprecated, I plan to open a separate issue for that.

+++ b/core/lib/Drupal/Component/Utility/UrlHelper.php
@@ -82,7 +83,10 @@ public static function buildQuery(array $query, $parent = '') {
-  public static function filterQueryParameters(array $query, array $exclude = array(), $parent = '') {
+  public static function filterQueryParameters(array $query = NULL, array $exclude = array(), $parent = '') {
+    if (!isset($query)) {
+      $query = \Drupal::request()->query->all();
+    }

We shouldn't call \Drupal from OO code - dependencies should be injected so they can be tested, calling \Drupal makes this method silently depend on the Request object.

Instead, we should correct any places that are currently not passing $query and ensure they do. I suggest we split that off into it's own issue so as not to delay conversion of the other functions.

~/d8codetools/function_replace.php check_url 'Drupal\Component\Utility\UrlHelper' UtilityUrlHelper checkUrl

There is no 'checkUrl' function on UrlHelper. This actually wraps two functions, String::checkPlain(UrlHelper::stripDangerousProtocols($uri));. Again, let's leave this for now.

New function replace commands:

~/d8codetools/function_replace.php drupal_http_build_query 'Drupal\Component\Utility\UrlHelper' UtilityUrlHelper buildQuery
~/d8codetools/function_replace.php drupal_parse_url 'Drupal\Component\Utility\UrlHelper' UtilityUrlHelper parse
~/d8codetools/function_replace.php drupal_encode_path 'Drupal\Component\Utility\UrlHelper' UtilityUrlHelper encodePath
~/d8codetools/function_replace.php _external_url_is_local 'Drupal\Component\Utility\UrlHelper' UtilityUrlHelper externalIsLocal
~/d8codetools/function_replace.php valid_url 'Drupal\Component\Utility\UrlHelper' UtilityUrlHelper isValid
~/d8codetools/function_replace.php url_is_external 'Drupal\Component\Utility\UrlHelper' UtilityUrlHelper isExternal

I've reviewed the other commands, and they are good.

That patch looks good, except for a couple of comments / test messages that weren't updated, but it catches everything else correctly.

Here's a patch with those small changes.

I have spoken to webchick and she suggested that she would be available to review/commit this next Monday, 31st March. There's little point in rerolling the patch until the weekend, but if there's a patch here on Monday that applies then I'll review it.

Looks good. I've confirmed #11 is a good reroll of #6, which was RTBC.

Simple reroll, just conflicting context in the use statements. Diffing this against #11 shows no other changes.