The watchdog messages that log geocoding errors are helpful to assist in figuring out what type of errors we are getting. What would be helpful is a link in the watchdog entry that points to the entity that contains the field that caused the error. This would be very helpful in determining what entities have bad addresses, for example.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | geocoder--link-to-offending-entity--2221663-3.patch | 1.22 KB | mpgeek |
| #2 | geocoder--link-to-offending-entity--2221663-2.patch | 1.2 KB | mpgeek |
| #1 | geocoder--link-to-offending-entity--2221663-1.patch | 1.4 KB | mpgeek |
Comments
Comment #1
mpgeek commentedHere is a patch that adds the link on the watchdog message detail page. Note that the google handler was double-wrapped in a try-catch block, so we had to change that to a re-throw to let the widget actually handle the exception.
Comment #2
mpgeek commentedHere is a cleaner patch, some debug code was removed.
Comment #3
mpgeek commentedGah. One more time, as field_collections are throwing warnings.
Comment #5
polThanks! It's in now.
Comment #9
adamps commentedUnfortunately this check-in seems to have broken #2408693: Handle not every Exception as a watchdog error
The Google code is carefully specifying different severity levels and now they are being ignored and it always uses WARNING (in the widget) or ERROR (in function geocoder).
Yandex also catches its own exceptions and that code was left in place. This is good in that yandex exception severity levels weren't broken, but presumably bad in that this fix isn't applied to yandex.
In fact errors and exceptions all seem to be a bit muddled right now - I've raised a new issue #2689211: Confusion with errors and logging.