Rename default 'cache' cache bin to 'default'

Here is an initial patch, let's see what fails.

The main issue with trying to rename this is that in conflicts with our current directive of using 'default' under the cache settings in settings.php to change the default backend for all bins. Spoke to catch briefly about this. We could nest the per bin stuff one level deeper. So

$settings['cache']['default'] = 'my.default.bin';
$settings['cache']['my_bin'] = 'my.cache.bin';

Would become:

$settings['cache']['default'] = 'my.default.bin';
$settings['cache']['bins']['my_bin'] = 'my.cache.bin';

1: 2221065.patch queued for re-testing.

Conflicted in migration.services.yml.

5: 2221065-5.patch queued for re-testing.

5: 2221065-5.patch queued for re-testing.

We know this will fail - just re-testing so we can see/debug this on the bot servers.

Re-roll.

Hopefully this will fix those...

Reroll.

15: 2221065-15.patch queued for re-testing.

Rerolled after cache bins re-organisation.

Reroll fun.

This should at least allow Drupal to be installed again :)

HAHA, yes. That will indeed help.

Apologies, the reroll in @#20 was completely wrong (see the size) and the subsequent rerolls were based on that, which is just trying to redo work already done.

Another reroll based on #18.

Hah :)

Fixing issue title to prevent confusion.

That said, I'm a bit terrified by the amount of instances of "default" in the D8 code base, all having different meanings... And for a cache bin, I wonder whether "default" really is an appropriate term, given that each bin has a clear use-case, and the "default" bin should only be the last resort...?

I don't want to start a bikeshed, but how about naming it "misc" instead of "default"?

"misc" == Dumping ground for miscellaneous stuff that doesn't fit into any of the other bins for any reason.

Seems like that is that start of a bikeshed to me .... :)

That said, I'm a bit terrified by the amount of instances of "default" in the D8 code base

Seems a bit extreme? Did you just grep for 'default' or something?!

Default is a popular word. This seems like a logical use of 'default', plus this is the default cache bin, so the name is apt IMO. I'm sorry but misc is not a good name.

Rerolled.

I agree with #30 completely. "default" is clear, it's just used in many different contexts, not in different meanings.

Only context changes, so back to RTBC.

34: 2221065-34.patch queued for re-testing.

Just a rerolled with above change for the library discovery patch. I think this can still be RTBC.