Updated: Comment #N

Problem/Motivation

On ViewExecutable there are two methods for returning data about the various plugins a view uses. One if getPluginTypes() and the other is viewsHandlerTypes(). This is not very consistent. Let's rename.

Proposed resolution

Rename viewsHandlerTypes method to getHandlerTypes(). This is more in line with getPluginTypes, and other naming in core.

Remaining tasks

Do it.

User interface changes

None

API changes

ViewExecutable::viewsHandlerTypes() will be renaming, although this is mostly going to be used by views itself.

CommentFileSizeAuthor
#15 interdiff-2219661-15.txt1.31 KBdamiankloip
#15 2219661-15.patch21.5 KBdamiankloip
#9 2219661-9.patch20.88 KBdamiankloip
#3 interdiff-2219661-3.txt678 bytesdamiankloip
#3 2219661-3.patch20.85 KBdamiankloip
#1 2219661.patch20.19 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
StatusFileSize
new 2219661.patch20.19 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2219661.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 2219661-3.patch20.85 KB
new interdiff-2219661-3.txt678 bytes

Thanks phpstorm.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

This should be pretty straightforward.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2219661-3.patch, failed testing.

damiankloip’s picture

damiankloip commented

3: 2219661-3.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Reviewed & tested by the community

really?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2219661-3.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 2219661-9.patch20.88 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 9: 2219661-9.patch, failed testing.

damiankloip’s picture

damiankloip commented

HEAD is failing?

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review

9: 2219661-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: 2219661-9.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs reroll
damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2219661-15.patch21.5 KB
new interdiff-2219661-15.txt1.31 KB

Gah, config dependencies stuffs happened.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

consistency++

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 021900b on 8.x by catch: 
    Issue #2219661 by damiankloip: Rename ViewExecutable::viewsHandlerTypes...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.