After upgrading to wetkit 1.3 I've noticed this message in the watchdog that occurs when viewing a solr facet page.

Notice: Undefined index: [2013-11-01T00:00:00Z TO 2013-12-01T00:00:00Z] in _date_facets_api_facet_create_label() (line 65 of wetkit_distro1.3/profiles/wetkit/modules/contrib/date_facets/date_facets.module).

CommentFileSizeAuthor
#10 wetkit_search-date-facets-undefined-index-2219547-10.patch614 bytesjoseph.olstad
#9 date_facets-undefined-index-2219547-9.patch560 bytesjoseph.olstad
#5 date_facets-undefined-index-2219547-5.patch560 bytesjoseph.olstad

Comments

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Closed (won't fix)

Actually, it is part of the distro. date facets

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Closed (won't fix) » Needs work

investigating

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

SOLUTION?
LINE 65 of profiles/wetkit/modules/contrib/date_facets/date_facets.module

BEFORE:

 // Pull the correct display value from the range definitions.
  foreach ($values as $key => $value) {
    $map[$value] = $ranges[$value]['#markup'];
  }

AFTER:

  // Pull the correct display value from the range definitions.
  foreach ($values as $key => $value) {
  if (isset($ranges[$value]['#markup'])) {
      $map[$value] = $ranges[$value]['#markup'];
    }
  }
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new date_facets-undefined-index-2219547-5.patch560 bytes

suggested patch to date_facets
needs review

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
sylus’s picture

sylus commented
Status: Needs review » Reviewed & tested by the community

Hey this looks good to me but I think you should make a patch to the date_facets module and link to it here so everyone else can get this patch.

Marking this as RTBC for us though.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #2220227: Undefined index in _date_facets_api_facet_create_label

Adding parent issue ( upstream in date_facets , same patch)

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new date_facets-undefined-index-2219547-9.patch560 bytes

Ok, here's the patch I'll use for wetkit_search.
follow up with commit for wetkit_search using this patch for date_facets

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new wetkit_search-date-facets-undefined-index-2219547-10.patch614 bytes

I couldn't push to git.drupal.org , return code 22 fatal

So here's a patch for wetkit_search to bring in the patch from comment 9 for the distro build

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

git remote set-url origin my.name@git.drupal.org:project/wetkit_search

git push
my.user's password: XXXXXXXXX
You do not have write permissions for the 'wetkit_search' repository.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: Unassigned » joseph.olstad
Status: Reviewed & tested by the community » Fixed

Committed patch 9 to wetkit_search

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.