Issue

The oa_radix theme makes use of the Conditional Stylesheets module in the .info file to set certain CSS files conditionally:

; CSS - Conditional
stylesheets-conditional[IE 7][all][] = assets/stylesheets/ie7.css
stylesheets-conditional[IE 8][all][] = assets/stylesheets/ie8.css

However the Conditional Stylesheets module is not included in the Open Atrium profile.

Solution

Add the Conditional Stylesheets module to the Open Atrium profile (in modules/contrib/) by default.

(I've not really worked with profiles before, I can see that the module would need to be added to the .info file, but surely it would also need to be added to the .make files as well? I couldn't see where the other required contrib modules were sitting though, sorry, otherwise I would have rolled a patch.)

Comments

  • Commit 4813e43 on 7.x-2.x by mpotter: 
    Issue #2219501 by .John: Conditional styles module missing from profile.
mpotter’s picture

mpotter commented
Status: Active » Fixed

Committed this to db3b6ef in oa_core and 4813e43 for the openatrium distro.

Although this doesn't have much effect since the ie7.css and ie8.css files are empty.

jkingsnorth’s picture

jkingsnorth commented

Oh it was just a case of adding it to the info. Fair enough! I just spotted this because we were using the conditional_styles format in our sub_theme - since they were in the .info file for oa_radix I assumed that it was enabled.

I didn't realise the files were empty in radix though - strange for them to be there at all if they're empty.

Thanks though mpotter.

mpotter’s picture

mpotter commented

It was adding to the info file, but then also adding to the oa_core.make file and also adding an update hook to enable the module for existing users.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.