a couple of configs use more than 2 spaces in...

  1. migrate_drupal/config/migrate.migration.d6_menu_settings.yml
  2. migrate_drupal/config/migrate.migration.d6_search_settings.yml
CommentFileSizeAuthor
#4 2219121-migrate_drupal-config-spacing-4.patch2.34 KBbdone
#1 imp-2219121-1.patch2.2 KBbdone

Comments

bdone’s picture

bdone commented
Assigned: bdone » Unassigned
Status: Active » Needs review
StatusFileSize
new imp-2219121-1.patch2.2 KB
benjy’s picture

benjy commented
Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system
Issue tags: +Needs reroll

Needs a re-roll, moving to core.

benjy’s picture

benjy commented
Status: Needs review » Needs work
bdone’s picture

bdone commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2219121-migrate_drupal-config-spacing-4.patch2.34 KB

a quick re-roll using two space indentations.

benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks.

The last submitted patch, 1: imp-2219121-1.patch, failed testing.

My_Dessert’s picture

My_Dessert commented

Thanks :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b69a778 and pushed to 8.x. Thanks!

  • Commit b69a778 on 8.x by alexpott: 
    Issue #2219121 by bdone: Remove spacing issue in config/*.yml.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.