The layout is supposed to be a two full-width header regions, followed by a four column region, followed by two two-column regions, followed by another full-width footer region.

CommentFileSizeAuthor
#8 2218233-8-fix-jerusalem-marble.patch20.4 KBjessehs
#7 2218233-7-fix-jerusalem-marble.patch20.41 KBjessehs
#5 2218233-5-fix-jerusalem-marble.patch20.4 KBjessehs
#4 2218233-4-fix-jerusalem-marble.patch18.32 KBjessehs
#3 2218233-3-fix-jerusalem-marble.patch14.93 KBjessehs
#2 2218233-2-jerusalem-marble.patch15.82 KBjessehs
#1 2218233-1-jerusalem-marble.patch12.87 KBjessehs
#1 jerusalem_marble.png1.06 KBjessehs
fixing-jerusalem-marble.patch9.75 KBjessehs

Comments

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Issue summary: View changes
StatusFileSize
new jerusalem_marble.png1.06 KB
new 2218233-1-jerusalem-marble.patch12.87 KB
jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
StatusFileSize
new 2218233-2-jerusalem-marble.patch15.82 KB

There's still something weird going on at the medium breakpoint.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
StatusFileSize
new 2218233-3-fix-jerusalem-marble.patch14.93 KB

This adds a wrapper element for each pair of regions in the 4 column-row. Also adds containers for each row of the layout so the layout can be themed to 100% window with for each row of the layout.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
StatusFileSize
new 2218233-4-fix-jerusalem-marble.patch18.32 KB

Patch in #3 is missing a bunch.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
StatusFileSize
new 2218233-5-fix-jerusalem-marble.patch20.4 KB

This patch removes the container logic (this should be in the theme).

anniegreens’s picture

anniegreens commented

@jessehs, I will take a look at these. I know we discussed in person.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Issue summary: View changes
StatusFileSize
new 2218233-7-fix-jerusalem-marble.patch20.41 KB

This patch adjusts grid-span on the 4-columns for the large and xlarge breakpoints so they're all 4 exactly even. It also adds a new region "Content Header Top".

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
StatusFileSize
new 2218233-8-fix-jerusalem-marble.patch20.4 KB

The last patch had the row-wrapper for header and header top regions mixed up so it could not be styled full-width.