Been working on this for the past year or so.

Finally made good progress.

CommentFileSizeAuthor
#11 cck-select-other-2216605-fix-view-elements.patch622 bytesmradcliffe
#4 cck_select_other-2216605-drupal8-fixes-4.patch31.74 KBmradcliffe
#3 cck_select_other-2216605-drupal8-fixes-3.patch31.36 KBmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

Spent a couple of hours writing a single test case.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

Everything but views support and multi-value fields seems to be workin. Tests from Drupal 7 ported to Drupal 8.

  1. Need to figure out the best way to do the filter / field in Drupal 8 views.
  2. Multi-value fields are being flipped when loaded into the widget. Also from my the test I wrote I can see that multiple values are being flipped during render. This means that 0 becomes 2 and 2 becomes 0 for a cardinality of 3. Weird.

I've committed initial work.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new cck_select_other-2216605-drupal8-fixes-3.patch31.36 KB

Fixes issues with drupal core changes.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new cck_select_other-2216605-drupal8-fixes-4.patch31.74 KB

Forgot to add new config directory.

  • mradcliffe committed 67234ed on 8.x-1.x 
    Issue #2216605: Fix module to work with changes to core.

  • mradcliffe committed 0af4277 on 8.x-1.x 
    Issue #2216605: Fix default_value schema for config entities in tests.

  • mradcliffe committed 296f56c on 8.x-1.x 
    Issue #2216605 by mradcliffe: Fix multiple value test to use xpath as...

The last submitted patch, 3: cck_select_other-2216605-drupal8-fixes-3.patch, failed testing.

The last submitted patch, 3: cck_select_other-2216605-drupal8-fixes-3.patch, failed testing.

  • mradcliffe committed 742f926 on 8.x-1.x 
    Issue #2216605 by mradcliffe: Fix javascript to use field delta so that...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new cck-select-other-2216605-fix-view-elements.patch622 bytes

Fix for viewElements.

  • mradcliffe committed a930e1d on 8.x-1.x 
    Issue #2216605 by mradcliffe: Fix api change in viewElements method.

  • mradcliffe committed 5155ee2 on 8.x-1.x 
    Issue #2216605: Add views support and refactor entity form display...

  • mradcliffe committed 64ed0ef on 8.x-1.x 
    Issue #2216605 by mradcliffe: Fix typo error in previous commit with...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Should be feature complete for Drupal 8 except for migrate. Opened follow-up issue #2606060: Migrate select other field widget allowed values to allowed values.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 3: cck_select_other-2216605-drupal8-fixes-3.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 11: cck-select-other-2216605-fix-view-elements.patch, failed testing.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Closed (fixed)

Urrrrgh.