While the bootstrap_btn_dropdown theme hook was "technically" converted, it really didn't undergo any real scrutiny.

http://getbootstrap.com/components/#dropdowns
http://getbootstrap.com/components/#btn-dropdowns
http://getbootstrap.com/javascript/#dropdowns

The following issues need improvement:

  • Theme hook name is inaccurate. The dropdown isn't always triggered by a button.
  • Label processing in general needs improvement. It's not always a link, it could be a button or a split button. It should also support custom icons
  • Attribute/class processing.
  • Link processing:
    • These links aren't even using the bootstrap_links theme hook, which is what it was created for (there's a lot of "dropdown" specific code in this theme hook). It should just be merged into this one.
    • Need option to right align menu.
    • Option processing:
      • A way to group links (using headers and dividers)
      • Control disabled state
      • Icon support

Comments

markhalliwell’s picture

Title: Refactor the dropdown theme hook » Refactor bootstrap dropdowns

Committed 06e37df to 7.x-3.x:

Issue #2215747 by Mark Carver: Refactor bootstrap dropdowns.

markhalliwell’s picture

Status: Active » Fixed
markhalliwell’s picture

Version: 7.x-3.x-dev » 8.x-3.x-dev
Assigned: Unassigned » ryan.armstrong
Priority: Normal » Critical
Status: Fixed » Needs review

  • Commit 06e37df on 7.x-3.x, 8.x-3.x by Mark Carver:
    Issue #2215747 by Mark Carver: Refactor bootstrap dropdowns.
    

  • Mark Carver committed 06e37df on 8.x-3.x.x
    Issue #2215747 by Mark Carver: Refactor bootstrap dropdowns.
    
markhalliwell’s picture

Version: 8.x-3.x-dev » 7.x-3.x-dev
Assigned: ryan.armstrong » Unassigned
Status: Needs review » Closed (fixed)

I'm just moving this back to 7.x. If this needs re-evaluation in 8.x, create a new issue.