Problem/Motivation

Site admin "disables developer modules" and magically sees any modules that depend on commerce_product_pricing get disabled (along with commerce_product_pricing module itself). Due to the fact that "rules_admin" is marked as a dependency in the commerce_product_pricing.info file it gets disabled when "disabling developer modules".

Proposed resolution

Apply the patch (if possible) and remove the dependency in commerce_product_pricing.info file. Note that the dependency should remain in commerce_product_pricing_ui.info file.

Remaining tasks

[] Discuss change with Project Maintainers
[] Apply patch

CommentFileSizeAuthor
#1 commercedevelopermodfix-2215163.patch457 bytesstevesmename

Comments

stevesmename’s picture

StatusFileSize
new457 bytes
stevesmename’s picture

Status: Active » Needs review
rszrama’s picture

Category: Bug report » Task

Not really a bug. Let's just make sure it's all kosher and that the UI module has the requisite dependencies in place.

rszrama’s picture

Wait, maybe I'm not understanding how you've phrased the original post, but it doesn't read correctly to me. Why would Commerce Product Pricing be considered's a developer module? Are you sure it's not being disabled because it depends on Rules UI, not vice versa?

stevesmename’s picture

Guess I was speaking on behalf of the customer. The customer had a custom module that extended functionality from Commerce Product Pricing. The customer is hosted on a Drupal hosting company and the hosting company highly suggests to turn off UI modules by Disabling Developer Modules. With the admin_menu module you get the ability to Disable Developer Modules, when developer clicks this functionality then Commerce Product Pricing is disabled because it depends on Rules UI and that in turns disable any custom modules.

bojanz’s picture

That admin_menu option is a dumb idea that constantly results in wrong modules getting disabled. I've seen it all over Commerce contrib, and wider.

andyg5000’s picture

Category: Task » Bug report
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

This bug is melting commerce sites around the globe!

Rules admin should only be a dependency of the commerce_product_pricing_ui module. Patch is good to go :D

rszrama’s picture

Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed

Pssh, it's melting Commerce sites that use an ill advised "feature" in Admin Menu that is. ; )

Committed.

  • Commit af9534a on 7.x-1.x authored by stevesmename, committed by rszrama:
    Issue #2215163 by stevesmename: remove the unnecessary dependency on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.