Hi,

I've just encountered two misspelled words. I will add my patch for it in the first comment.

Regards,
K.

CommentFileSizeAuthor
#5 2211621.patch1.47 KBlongwave
#1 misspelling-2211621-1.patch1.59 KBkartagis

Comments

kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented
Status: Active » Needs review
StatusFileSize
new misspelling-2211621-1.patch1.59 KB
kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented
Issue summary: View changes
kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Patch looks good except for

diff --git a/sites/default/default.settings.php b/sites/default/default.settings.php
old mode 100644
new mode 100755

This shouldn't be in there.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Priority: Normal » Minor
Status: Needs work » Needs review
StatusFileSize
new 2211621.patch1.47 KB
cs_shadow’s picture

cs_shadow commented

Patch #5 looks good to me. Fixes the typo.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

RTBC based on my original review and #6

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Misspelling » Spelling error in assertion message

Better title.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.