Closed (fixed)
Project:
ImageCache Actions
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Mar 2014 at 19:33 UTC
Updated:
20 Mar 2014 at 06:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
fietserwinWhat files and directories need their permissions to be fixed?
Comment #2
ram4nd commentedThis is for 7 for an example.
Comment #3
fietserwinI'm using Windows and I have no idea how to set and subsequently store and commit these permissions in git. but if your patch does just that, I will happily apply your patch and commit it.
This what I get on applying your patch:
if I subsequently look at the local changes I only see 2 files listed:
- customactions/imagecache_customactions.install
- watermark.inc
Comment #4
dman commentedYeah, a permissions-less (or different) file system probably won't take the change here in any meaningful way.
I could apply with
git apply fix_permissions_7.x_1.x-2211485-2.patch
and it seems to have the expected effect.
Yep, it's inappropriate (and probably an unintentional error) that a number of *files* were marked as executable.
As the patch applies clean, and I agree it does improve things technically (though the difference may not be apparent in any meaningful way)
and because I can, and Windows probably can't
I'll push this in.
https://drupal.org/commitlog/commit/6286/13094f51856b9a39688c56dd7d5ad24...
Described better at:
http://drupalcode.org/project/imagecache_actions.git/commitdiff/13094f51...
It will probably make no appreciable difference to Windows checkouts at all, or to anyone using the code right now.
It's just good practice.
Thanks for your attention to detail @ram4nd - it's valuable!
Does anyone think it's worth backporting to D6? I don't care enough, but it's easy.