Updated: Comment #N

Problem/Motivation

Basically everywhere else in core now has their own annotations. E.g. Block, Views plugins, CKEditor, Filter, etc... We still use the generic PluginID annotation for all handler types.

Proposed resolution

Add a specific annotation for each views handler type. ViewsField, ViewsArea, ViewsSort, ViewsFilter, ViewsRelationship, ViewsArgument

Remaining tasks

Do it

User interface changes

None

API changes

Switch in annotations to domain specific ones.

CommentFileSizeAuthor
#5 2211235-5.patch93.35 KBdamiankloip
#3 2211235-3.patch99.56 KBdamiankloip
vdc.handler-annotations.patch93.2 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, vdc.handler-annotations.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Initial patch has patch from #2204635: Convert ViewsHandlerManager to DefaultPluginManager included. As that is not committed yet, but should be soon. We will want that for this.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
2211235-3.patch99.56 KB

Sorry, didn't diff against 8.x!!

My comment in #2 still applies here.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +DX (Developer Experience)

+1 for the idea in general!

Let's wait on the other issue and get it in. This is a improvement for the DX.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
2211235-5.patch93.35 KB

#2204635: Convert ViewsHandlerManager to DefaultPluginManager is in. Rerolled to remove that from the patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Awesome! Thank you for that quite big patch.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2211235-5.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review

5: 2211235-5.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2211235-5.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review

5: 2211235-5.patch queued for re-testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 53852c2 on 8.x by catch: 
    Issue #2211235 by damiankloip: Add specific annotations for Views...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.