Formatter should use proper method to access its settings.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

There's some issues that get test failures in Drupal\comment\Tests\CommentPagerTest
At least in #2099131-44: Use #pre_render pattern for entity render caching

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Nice catch

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andypost’s picture

Status: Closed (fixed) » Needs review
FileSize
995 bytes

And one more place

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

if green

andypost’s picture

FileSize
1.6 KB
2.14 KB

And one more place, checked

andypost’s picture

Title: Use getSetting() in comment formatter » [Followup] Use getSetting() in comment formatter
FileSize
2.39 KB
4.53 KB

Added test and re-roll.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Committed and pushed to 8.x.

  • Commit d1a751e on 8.x by webchick:
    Issue #2210177 by andypost: [Followup] Use getSetting() in comment...
andypost’s picture

Title: [Followup] Use getSetting() in comment formatter » Use getSetting() in comment formatter

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.