Formatter should use proper method to access its settings.

CommentFileSizeAuthor
#8 2210177-8.patch4.53 KBandypost
#8 interdiff.txt2.39 KBandypost
#7 2210177-7.patch2.14 KBandypost
#7 interdiff.txt1.6 KBandypost
#5 2210177-5.patch995 bytesandypost
comment-formatter.patch1.1 KBandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Quick fix
Related issues: +#2099131: Use #pre_render pattern for entity render caching

There's some issues that get test failures in Drupal\comment\Tests\CommentPagerTest
At least in #2099131-44: Use #pre_render pattern for entity render caching

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Nice catch

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 2210177-5.patch995 bytes

And one more place

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

if green

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt1.6 KB
new 2210177-7.patch2.14 KB

And one more place, checked

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Use getSetting() in comment formatter » [Followup] Use getSetting() in comment formatter
StatusFileSize
new interdiff.txt2.39 KB
new 2210177-8.patch4.53 KB

Added test and re-roll.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Committed and pushed to 8.x.

  • Commit d1a751e on 8.x by webchick: 
    Issue #2210177 by andypost: [Followup] Use getSetting() in comment...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: [Followup] Use getSetting() in comment formatter » Use getSetting() in comment formatter

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.