After #2084421: Phase 2 - Decouple book module schema from menu links landed I noticed a few inconsistencies with how we're documenting BookManagerInterface. Most of the time we're using the full namespace for defining the interface where it's found in the documentation. But in two different places we're using the shorthand method of just declaring the interface by name.

This patch fixes those instances to use the full namespace instead.

CommentFileSizeAuthor
#1 2208395.patch893 bytescosmicdreams

Comments

cosmicdreams’s picture

cosmicdreams commented
StatusFileSize
new 2208395.patch893 bytes
cosmicdreams’s picture

cosmicdreams commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Fine for now.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Incidentally, the docs standards just say that if you use a namespace in docs, you should use the fully-qualified namespace. But if the interface is in a Use statement, there is not really a need to include the namespace. I have no problem with the patch, but just pointing out that the existing docs do not violate any of our standards as far as I am aware, and should not cause any problems for api.drupal.org (or I would hope, any IDE).

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks -- committed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.