_menu_navigation_links_rebuild has poorly-written comments:

  // Updated items and customized items which router paths are gone need new
  // router paths.

s/which/whose

  // Find any items where their router path does not exist any more.

s/where their/whose yet again.

CommentFileSizeAuthor
#9 menu_rebuild_comments-220827-9.patch1.58 KBcburschka
#6 _menu_navigation_links_rebuild.patch1.6 KBax
#4 _menu_navigation_links_rebuild.patch891 bytesax
#1 _menu_navigation_links_rebuild.patch1.6 KBax

Comments

ax’s picture

ax commented
Component: menu system » documentation
Status: Active » Reviewed & tested by the community
StatusFileSize
new _menu_navigation_links_rebuild.patch1.6 KB

made a patch. it's 2 comment lines, so i set it to rtbc.

catch’s picture

catch
he/him
Primary language English
commented

Changes looks good.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Patch no longer applies. Oops.

ax’s picture

ax commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new _menu_navigation_links_rebuild.patch891 bytes

it applies cleanly against DRUPAL-6, for which it is filed. attached a patch against HEAD.

cburschka’s picture

cburschka
they
commented

The HEAD patch is missing the first correction to _menu_navigation_links_rebuild ("which"). Leaving as RTBC for D6, however.

ax’s picture

ax commented
StatusFileSize
new _menu_navigation_links_rebuild.patch1.6 KB

sorry, had a somehow sticky HEAD version here with a menu.inc not up-to-date. new patch against HEAD has both corrections.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-dev » 7.x-dev

Committed #1 to 6.x. Still RTBC for 7.x (for which #6 was rolled).

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

This patch no longer applies and needs to be re-rolled.

cburschka’s picture

cburschka
they
commented
Title: Doxygen comments, bad English » _menu_navigation_links_rebuild comments have bad English
Status: Needs work » Needs review
StatusFileSize
new menu_rebuild_comments-220827-9.patch1.58 KB

Fixed title because these aren't actually doxygen comments. Rerolled, too.

floretan’s picture

floretan commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly to HEAD.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.