Can not configure editor whilst creating a new text format

Check if filter format exists, before calling the member functions related to filter format.

#1 is working fine for me. Now i am able to add new text format with editor.

#2207777: Can not configure editor whilst creating a new text format was a duplicate of this one.

#1: thanks for working on this! :) And great to see it confirmed in #2 that this fixes the problem. But this still needs test coverage, so back to NW.

This is a regression caused by #2204129: Store the filter format on the editor entity during runtime.

Test coverage added. Applied the same principle as #1, but I put it in a helper method that makes the code more legible than a if ($object) {…} test.

We did have test coverage for the generic use case at EditorAdminTest::testAddEditorToNewFormat(), but in that case there was no code trying to do things based on the associated FilterFormat. Therefore the new test coverage lives at CKEditorAdminTest::testNewFormat().

#4 was silly, #2229801: Adding text format error for CKEditor is the duplicate.

5: text_editor_new_format-2207777-1.patch queued for re-testing.

Looks good to me, except:

+++ b/core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/CKEditorPlugin/Internal.php
@@ -285,9 +285,16 @@ protected function generateFormatTagsSetting(Editor $editor) {
+    // When no text format is associated yet, assume nothing is disallowed, so
+    // set allowedContent to true.
+    if (!$editor->hasAssociatedFilterFormat()) {
+      return TRUE;
+    }

This sounds dangerous, to allow all content by default if there was no filter?! What is the use case for this?

#9: that only happens on the form to configure text formats & text editors. Even then, it only happens if you create a new text format, and before saving that text format, you already associate a text editor.

Plus, this only applies to CKEditor's own filtering. It does not affect what's rendered to end users in any way.

All right then. Looks good.

Trivial reroll after #2030605: Expand Editor with methods introduced some very minor changes.

Sorry, conflicts after CKE 4.4 :(

#13 and #15 included the #2241235: Shortcut/ShortcutSet entity types should use cache tags patch by accident. Proper reroll.

Back to RTBC per #11. This only got marked NW because it didn't apply anymore after #2039163: Update CKEditor library to 4.4 landed.

It looks like there's a regression for this in Drupal 9. The ajax error is:

An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /admin/config/content/formats/add?ajax_form=1
StatusText: OK
ResponseText: AssertionError: Cannot load the "filter_format" entity with NULL ID. in assert() (line 244 of /var/www/arvestbank/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php).

I am also seeing this behavior in Drupal 8.9.13.

@damondt did you find any solution for this? I'm stcuk with this too.

@tejasvi.c.h If I recall correctly, you have to first add and save the text format. Then go back and edit the CKEditor config.

D9 experienced the same #23, #26 is the workaround. Reopen and change to minor?