Hi,
Is there plans to introduce D8 version of this module?
We (@InternetDevels team) would like to help you with development of this version.
Thanks, @ipo4ka704.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drupal_8_x-2207363-3.patch | 8.21 KB | claudiu.cristea |
| #2 | token_filter-8.x.zip | 1.86 KB | chi |
Comments
Comment #1
pepperstreet commentedFollowing...
Any news or feedback on Drupal8 future releases?
TIA!
Comment #2
chi commentedThe filter for global tokens is simple enough. I am not sure whether we need Token module dependency to support entity tokens. Is it worth moving Token filter to that project?
Comment #3
claudiu.cristeaOuch! I created the patch and after I saw that there's some work done.
However, comparing my patch:
Comment #4
claudiu.cristeaA temporary location for 8.x-1.x branch here https://github.com/claudiu-cristea/token_filter
Comment #5
decipheredI've added a PR to @claudiu.cristea's repo re-adding the Entity token support (with the Token module dependency also re-added).
Comment #6
hannesvdt commentedHi, Is there any update on the module? Currently I can get tokens to render as default value. Any Tips or Tricks. Btw No errors for the moment.
Thx
Comment #7
decipheredI attempted to reach out to Dave a few times in hopes of getting this committed or getting committer access, but I haven't heard anything.
I'll try again tomorrow, and failing that I'll initiate the abandoned module process.
Comment #8
dave reidI'll add you Deciphered as a maintainer, feel free to provide the D8 port.
Comment #10
decipheredThanks Dave, appreciate that.
I note you gave me commit access but not access to edit the project page itself, which is not an issue at all, I'm happy to just be a committer, but it does mean that I'll need you (or someone) to update the text on the project page to be inclusive of Drupal 8.
Comment #11
jibranComment #12
darvanenIs this where we can discuss a release candidate and the eventual ticking of the security inclusion box?
Comment #13
murzThanks for porting, I have tested Token Filter for Drupal 8.x and it works well with most of tokens, but got the problem with insert formatted field value: it inserted with html tags converted to entities, so on page I see
<p>Text</p>instead ofText. How can I fix this problem?Comment #14
darvanen@Murz I think that warrants a new issue as it's probably a bug.
Can you create a new issue with steps to reproduce so it can be looked at?
Comment #15
darvanenComment #16
jonathan1055 commentedWhy is this issue marked as fixed when Token Filter only has a beta release for 8.x? The IS says
which implies that this issue should only be fixed when a full 8.x-1.0 release is made.
Or maybe if I have mis-understood something then the issue summary and title should be changed.
Comment #17
darvanenYou're absolutely right, I must have got carried away with the spring cleaning in here and the idea that a beta version is still a version.
I think the beta is ready to be a release candidate at the least, but would welcome any reviews to help push that along. If there hadn't been a commit sitting in the dev branch it would already be on RC, I just want to give that code a little time to pop up errors if it does.
Comment #18
jonathan1055 commentedOK, thanks for the explanation.
Also, just changing the title so that when this issue is listed in places other than the project issue queue (e.g. on user dashboard / blocks) then it is clear what it refers to.
Comment #19
karolus commentedWell, if it's any help, I just installed and enabled the build on a D8.5 site running PHP 7.1. All running nominally. What's needed to push to a full release now?
Comment #20
darvanenThanks @karolus
At this point the beta2 usage is nearly the same as beta1 and I haven't seen any new issues come in, so I'll release a stable version when I get home tonight.
Comment #21
darvanenStable release now available.
Comment #22
jonathan1055 commentedThank you all. It's good to have a full 8.x release.