Moderation users can still publish comments by email - I found a temporary workaround (hack) by adding the following around line 491 in feeds_comment_processor/FeedsCommentProcessor.inc

$edit['status'] = COMMENT_NOT_PUBLISHED;
    if (user_access('post comments without approval')) {
    	$edit['status'] = COMMENT_PUBLISHED;
    }

Let me know feedback and if there's a more permanent solution.

Thanks.

CommentFileSizeAuthor
#6 feeds_comment_processor-respect-perms-2206309-6.patch10.47 KBtwistor
#4 feeds_comment_processor-respect-perms-2206309-4.patch10.35 KBtwistor
#3 feeds_comment_processor-respect-perms-2206309-3.patch7.06 KBtwistor

Comments

MickC’s picture

MickC commented

I actually had some issues with the first solution - may have been picking up permissions from the active user rather than the comment user so here's a modification to specifically load the user in question and check roles - in this case the role 'moderated' is used for the purpose:

$edit['status'] = COMMENT_PUBLISHED;    
    $thisuser = user_load($edit['uid']);
    if (in_array('moderated', array_values($thisuser->roles))) {
        $edit['status'] = COMMENT_NOT_PUBLISHED;
    }
twistor’s picture

twistor commented
Version: 6.x-1.0-beta2 » 7.x-1.x-dev
twistor’s picture

twistor commented
Priority: Critical » Major
Status: Active » Needs review
StatusFileSize
new feeds_comment_processor-respect-perms-2206309-3.patch7.06 KB
twistor’s picture

twistor commented
StatusFileSize
new feeds_comment_processor-respect-perms-2206309-4.patch10.35 KB

The last submitted patch, 3: feeds_comment_processor-respect-perms-2206309-3.patch, failed testing.

twistor’s picture

twistor commented
StatusFileSize
new feeds_comment_processor-respect-perms-2206309-6.patch10.47 KB

The last submitted patch, 4: feeds_comment_processor-respect-perms-2206309-4.patch, failed testing.

  • twistor committed 5eb7cbd on 7.x-1.x 
    Issue #2206309 by twistor: Not respecting comments permission
twistor’s picture

twistor commented
twistor’s picture

twistor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.