Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
link.module
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Feb 2014 at 22:18 UTC
Updated:
29 Jul 2014 at 23:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mandar.harkare commentedComment #2
mandar.harkare commentedComment #3
mandar.harkare commentedAdded the patch.
Comment #4
rlmumfordLooks fine to me.
Comment #7
scor commented@mandar.harkare your patch format is wrong. Did you use Git to roll the patch? https://drupal.org/node/707484
Comment #8
mandar.harkare commentedNo, I used PHPStrom.
Comment #9
dineshw commentedcreating patch with using git diff on 8.x branch
$ git diff > [description]-[issue-number]-[comment-number].patch
$ git diff > typo-in-comment-2205159-9.patch
Comment #10
dineshw commentedComment #11
scor commented@mandar.harkare looks like phpStorm doesn't generate legit patch and might need to be tweaked. I use phpStorm but always revert to the command line to roll patches. Most people use the command line or a tool like one of those: https://drupal.org/node/777182
In any case, @dineshw's patch looks good to me.
Comment #12
webchickGood catch!
Committed and pushed to 8.x. Thanks!