Help text on the cart page.

CommentFileSizeAuthor
#14 help_text_for_cart_13.patch1.65 KBblueminds
#13 help_text_for_cart_12.patch2.91 KBblueminds
#12 help_text_for_cart_11.patch2.57 KBblueminds
#10 help_text_for_cart_10.patch574 bytescgalli
#9 help_text_for_cart_9.patch2.97 KBcgalli
#7 help_text_for_cart_7.patch3.5 KBcgalli
#3 help_text_for_cart_3.patch2.25 KBcgalli
help_text_for_cart.patch1.1 KBcgalli

Comments

cgalli’s picture

cgalli commented
Status: Active » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Works. Unsure about how much details we should provide here. Possibly fine for a start.

I just realised that the Cart translate tab shows "Translation" only as title.
Do we lack a real title? The other tabs all have some custom title.

cgalli’s picture

cgalli commented
StatusFileSize
new help_text_for_cart_3.patch2.25 KB

Trial. Added help text for each source page.
Looks a bit crowded.

cgalli’s picture

cgalli commented

@miro
Translation Cart it should be!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/ui/tmgmt_ui.module
@@ -1180,6 +1215,13 @@ function tmgmt_ui_help($path, $arg) {
+
+    // Find the type of source.
+    $source = arg(3) != NULL ? arg(3) : 'content';

This is unfortunately not that easy. The default is dynamic, based on what you have available.

I'd just leave this out and just say items or sources, something like locale_default items isn't useful either.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
cgalli’s picture

cgalli commented
Status: Needs work » Needs review
StatusFileSize
new help_text_for_cart_7.patch3.5 KB

Removed source type
Adusted css for overlay display

Status: Needs review » Needs work

The last submitted patch, 7: help_text_for_cart_7.patch, failed testing.

cgalli’s picture

cgalli commented
Status: Needs work » Needs review
StatusFileSize
new help_text_for_cart_9.patch2.97 KB

Reversed some style changes...

cgalli’s picture

cgalli commented
StatusFileSize
new help_text_for_cart_10.patch574 bytes

Alternatively to putting help text on every source page we could add a tool tip to all buttons.

The patch adds a 'title' attribute to the 'Add to cart' button

Status: Needs review » Needs work

The last submitted patch, 10: help_text_for_cart_10.patch, failed testing.

blueminds’s picture

blueminds commented
Status: Needs work » Needs review
StatusFileSize
new help_text_for_cart_11.patch2.57 KB

Rerolled #9, did minor cleanup.

blueminds’s picture

blueminds commented
StatusFileSize
new help_text_for_cart_12.patch2.91 KB

and with the title attribute for the add to cart button

blueminds’s picture

blueminds commented
StatusFileSize
new help_text_for_cart_13.patch1.65 KB

and removing source overview help text

The last submitted patch, 12: help_text_for_cart_11.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.