At some point in time the styling for the “Skip to main content” link in Seven was knocked out a bit. Let's fix it.

Let's be aware of the toolbar when it's in it's vertical position to.

CommentFileSizeAuthor
#7 Screenshot from 2014-03-12 19:38:57.png51.48 KBrob3000
#5 Screenshot from 2014-03-12 13:44:33.png98.77 KBrob3000
#4 interdiff-1-2.txt378 bytesmartin107
#4 seven-skip-content-link-2202385-2.patch445 bytesmartin107
#2 seven-skip-content-link-2202385-1.patch444 byteskjay
Screen Shot 2014-02-21 at 17.26.31.jpg152.26 KBlewisnyman

Comments

lewisnyman’s picture

lewisnyman
he/him
commented

kjay’s picture

kjay commented
Status: Active » Needs review
StatusFileSize
new seven-skip-content-link-2202385-1.patch444 bytes

system.module.css is overriding the skip links on pseudo classes active and focus by putting the 'skip to main content' link's position attribute back to 'static'. To avoid breaking things elsewhere, have patched to use a more specific class selector for the skip to main content link on pseudo classes active, focus and hover.

Original issue where this problem crept in: https://drupal.org/node/897638

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Needs work 
+++ b/core/themes/seven/style.css
@@ -64,6 +64,12 @@ ul.menu li.expanded {
+	position: absolute !important;

It looks like there is a whitespace error here. Make sure your text editor is configured to use two spaces instead of tabs.

Apart from that it looks fine. A bit of a shame we have to use !important

martin107’s picture

martin107 commented
Status: Needs work » Needs review
StatusFileSize
new seven-skip-content-link-2202385-2.patch445 bytes
new interdiff-1-2.txt378 bytes

whitespace removed.

rob3000’s picture

rob3000 commented
StatusFileSize
new Screenshot from 2014-03-12 13:44:33.png98.77 KB

i'm new to all this but i applied patch in comment #4. All works fine see attached.

lewisnyman’s picture

lewisnyman
he/him
commented

Hey Rob :) This bug is against the Seven theme, so you have to go to an admin page to test it out. I'm happy with the patch so once you've tested it works you can change the status to RTBC.

rob3000’s picture

rob3000 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2014-03-12 19:38:57.png51.48 KB

Hey LewisNyman,

Just tested out it out on the structure page ( attached ) and it all works fine still :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Much better! ;)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Needs work

The last submitted patch, 4: seven-skip-content-link-2202385-2.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Needs work » Fixed

Pretty sure the bot just wasn't as fast as @webchick.

rob3000’s picture

rob3000 commented

I was wondering why it failed ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.