After doing a standard install, enabling locale and making 1 request to the frontpage the next request to the frontpage will make 240 calls to ConfigFactory::get(). With the attached patch this drops to 112 - meaning that there are 229 calls to LocaleTranslation::getStringTranslation(). There is also a massive reduction in calls for logged in users.

CommentFileSizeAuthor
#6 interdiff.txt533 bytesbenjy
#6 2202143_6.patch1.92 KBbenjy
#1 interdiff.txt576 bytesalexpott
#1 2202143.1.patch1.92 KBalexpott
d8.config-get-locale.patch1.92 KBalexpott
xhprof - logged in.png164 KBalexpott
xhprof-not-logged-in.png161.1 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2202143.1.patch1.92 KB
new interdiff.txt576 bytes

Fixed typo

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +language-ui

The change looks good. The setting is more meaning we SHOULD translate English (from a code point of view it means we *need* to look up the translation in case it is there). From a user point of view, it is indeed about CAN translate English. Anyway, this is minor nitpicking since the patch looks good :)

vijaycs85’s picture

vijaycs85
Location London, UK
commented 
+++ b/core/modules/locale/lib/Drupal/locale/LocaleTranslation.php
@@ -100,9 +106,23 @@ public function getStringTranslation($langcode, $string, $context) {
+    $this->translateEnglish = NULL;

very minor: unset($this->translateEnglish); would be much better as this is a bool property and we are trying to reset it.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Needs work on the above, but mostly looks good :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +sprint
benjy’s picture

benjy commented
Status: Needs work » Needs review
StatusFileSize
new 2202143_6.patch1.92 KB
new interdiff.txt533 bytes

Re-rolled with #3 fixed.

Status: Needs review » Needs work

The last submitted patch, 6: 2202143_6.patch, failed testing.

benjy’s picture

benjy commented

6: 2202143_6.patch queued for re-testing.

benjy’s picture

benjy commented
Status: Needs work » Needs review
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community

looks good.

yesct’s picture

yesct commented

6: 2202143_6.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yay, performance!

Committed and pushed to 8.x. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.