Navbar now uses underscore 1.5.x, so if you update the Navbar module it will stop working in Panopoly. To make matters worse, the instructions on the Navbar project page incorrectly points to the wrong version of underscore to install. more info here https://drupal.org/node/2173449.

CommentFileSizeAuthor
#1 panopoly_admin-update_underscore_to_15x-2201695.patch887 bytesbarraponto

Comments

barraponto’s picture

barraponto
he / him
commented
Component: User interface » Admin
Category: Bug report » Task
Status: Active » Needs review
StatusFileSize
new panopoly_admin-update_underscore_to_15x-2201695.patch887 bytes
lsolesen’s picture

lsolesen commented

This should probably be done together with #2181079: Update to Navbar 1.8. This should not be fixed for it self.

barraponto’s picture

barraponto
he / him
commented

If it doesn't hurt (breaks stuff, etc) I think it is easier to upgrade in manageable bytes.

wu-lee’s picture

wu-lee commented

Yes. Until it is fixed it one way or the other, it's going to trip up users like me who run a security upgrade and then find their site is broken. Thus my vote would be for fixing it sooner rather than later.

To elaborate: my recent upgrade of my panopoly install was quite problematic, this was just the last of various failures to work around. Tracking this one down here took me quite some time of trying one thing and another, since it wasn't clear that it was a panopoly problem. It looks like a navbar problem, and my attempts to upgrade underscore just made matters worse (installed the drupal underscore module, updated underscore.js, found it still didn't work - uninstalling the underscore module was necessary). I only thought of looking here when I grepped the source code for underscore and saw it in profiles/panopoly/libraries/underscore/.

For the benefit of other users googling for issues related to a broken admin menu, as evidenced by "_ is not defined" errors in the browser's javascript console, this is why. You *can* fix it by installing a new version of underscore.js in sites/all/libraries/underscore.js, and in fact I did it like this:

    drush dl underscore
    drush en -y underscore
    drush underscore-download
    drush dis underscore # this bit is important
    drush libraries-list
    rm -rf sites/all/modules/underscore

but that's not really the right way, since you end up with two copies of underscore. Presumably it is better to update the contents of profiles/panopoly/libraries/underscore/ manually.

barraponto’s picture

barraponto
he / him
commented

@wu-lee updating a single module from a distribution is tricky. You're better off updating all off the distribution bundle when it's released.

  • Commit a8bb9ca on 7.x-1.x by dsnopek: 
    Update Panopoly Admin for #2201695: Update library to underscore 1.5.x.
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Thanks @barraponto! I've confirmed that the old Navbar continues to work with the newer version of Underscore and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.