the query that pulls comments metadata to build the metadata tables is not properly excluding unpublished comments. attached should correct. untested.

CommentFileSizeAuthor
#2 comment_unpub_metadata_fix.patch1.51 KBhunmonk
#1 comment_unpub_metadata_fix.patch1.29 KBhunmonk
comment_unpub_metadata_fix.patch1.29 KBhunmonk

Comments

hunmonk’s picture

hunmonk commented
StatusFileSize
new comment_unpub_metadata_fix.patch1.29 KB

missed putting the table for timestamp. this one should do it.

hunmonk’s picture

hunmonk commented
StatusFileSize
new comment_unpub_metadata_fix.patch1.51 KB

one more thing. since not all comments might have an entry in the static array, we should make sure one exists, otherwise return an empty string.

aclight’s picture

aclight commented
Status: Needs review » Reviewed & tested by the community

I tested this and it works as expected. RTBC.

hunmonk’s picture

hunmonk commented
Status: Reviewed & tested by the community » Fixed

committed to 5.x-2.x, deployed on d.o, et. all.

note that this approach eliminates metadata tables from being displayed in unpublished comments. imo this is acceptable because: a) they are not technically part of the metadata flow anymore from the users's perspective, so we're giving the admin a consistent display in terms of what the user sees, and b) it would be overkill to try and manage two different sets of metadata changes just to display a table in unpublished comments.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.