This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.

Problem/Motivation

In #2005716: Promote EntityType to a domain object we started to rename all $entity_info to $entity_type. In comment_views_data_alter() we still use foreach (\Drupal::entityManager()->getDefinitions() as $entity_type => $entity_info) {

Proposed resolution

Change $entity_type to $entity_type_id and $entity_info to $entity_type in comment_views_data_alter()

Remaining tasks

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 2201167-comment-view-data-alter-1.patch3.05 KBsidharthap

Comments

sidharthap’s picture

sidharthap
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2201167-comment-view-data-alter-1.patch3.05 KB

Here is a patch. The test passed on local environment.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Looks good, passes tests.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

2201167-comment-view-data-alter-1.patch no longer applies.

error: patch failed: core/modules/comment/comment.views.inc:603
error: core/modules/comment/comment.views.inc: patch does not apply
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Fixed
Issue tags: -Needs reroll

Huh? Seems fixed to me: http://drupalcode.org/project/drupal.git/commitdiff/6c1f8ce

commit 6c1f8ce915eb358275799c50701096fe5a81ddec
Author: Alex Pott <alex.a.pott@googlemail.com>
Date:   Tue Mar 4 13:27:58 2014 +0000

    Issue #2201167 by sidharthap: Comment_views_data_alter() is still using $entity_info.
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Yep I committed the patch and forgot to update the status. Thanks @longwave!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.