This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.

Problem/Motivation

There are three \Drupal::cache()->delete('comment_entity_info'); in comment.module. This cache key is never set as far I can see.

Proposed resolution

Remove the 3 lines of code.

Remaining tasks

User interface changes

None

API changes

None

CommentFileSizeAuthor
#7 2201149-remove-comment-entity-info-7.patch1.21 KBsandipmkhairnar
#3 2201149-remove-comment-entity-info-1.patch1.2 KBsidharthap
#1 2201149-remove-comment-entity-info-1.patch1.19 KBsidharthap

Comments

sidharthap’s picture

sidharthap
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2201149-remove-comment-entity-info-1.patch1.19 KB

Me also not found \Drupal::cache()->set('comment_entity_info'). I have removed the lines. Here is the patch.

Status: Needs review » Needs work

The last submitted patch, 1: 2201149-remove-comment-entity-info-1.patch, failed testing.

sidharthap’s picture

sidharthap
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2201149-remove-comment-entity-info-1.patch1.2 KB

ohh a new patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Saw this cache code earlier and thought it was strange, now I see it's not needed. Patch applies, tests pass => RTBC.

andypost’s picture

andypost
he/him
Primary language Russian
commented

rtbc +1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

2201149-remove-comment-entity-info-1_0.patch no longer applies.

error: patch failed: core/modules/comment/comment.module:241
error: core/modules/comment/comment.module: patch does not apply
sandipmkhairnar’s picture

sandipmkhairnar commented
StatusFileSize
new 2201149-remove-comment-entity-info-7.patch1.21 KB

Reroll Patch.

sandipmkhairnar’s picture

sandipmkhairnar commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: 2201149-remove-comment-entity-info-7.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

7: 2201149-remove-comment-entity-info-7.patch queued for re-testing.

sutharsan’s picture

sutharsan commented
Issue tags: -Needs reroll

Needs reroll tag removed.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

back to rtbc

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.