Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.
Problem/Motivation
There are three \Drupal::cache()->delete('comment_entity_info'); in comment.module. This cache key is never set as far I can see.
Proposed resolution
Remove the 3 lines of code.
Remaining tasks
- Write patch (novice)
- Review patch to check it fixes the issue, the change is properly documented and for coding standards. Provide test evidence (novice)
- Keep issue summary up to date (novice)
User interface changes
None
API changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2201149-remove-comment-entity-info-7.patch | 1.21 KB | sandipmkhairnar |
| #3 | 2201149-remove-comment-entity-info-1.patch | 1.2 KB | sidharthap |
Comments
Comment #1
sidharthapMe also not found \Drupal::cache()->set('comment_entity_info'). I have removed the lines. Here is the patch.
Comment #3
sidharthapohh a new patch.
Comment #4
longwaveSaw this cache code earlier and thought it was strange, now I see it's not needed. Patch applies, tests pass => RTBC.
Comment #5
andypostrtbc +1
Comment #6
alexpott2201149-remove-comment-entity-info-1_0.patch no longer applies.
Comment #7
sandipmkhairnar CreditAttribution: sandipmkhairnar commentedReroll Patch.
Comment #8
sandipmkhairnar CreditAttribution: sandipmkhairnar commentedComment #10
andypost7: 2201149-remove-comment-entity-info-7.patch queued for re-testing.
Comment #11
Sutharsan CreditAttribution: Sutharsan commentedNeeds reroll tag removed.
Comment #12
andypostback to rtbc
Comment #13
catchCommitted/pushed to 8.x, thanks!