Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi,
Is there plans to introduce D8 version of this theme?
We (@InternetDevels team) would like to help you with development of this version.
Thanks, tornado.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | ninesixty-d8-port-2200459-5.patch | 566.77 KB | id.tornado |
Comments
Comment #1
id.tornado CreditAttribution: id.tornado commentedHere is patch that ports Ninesixty theme to Drupal 8.
I am interested on further development of Ninesixty theme. Is there any chance of me joining the project as the maintainer?
Comment #2
ruplWow, that's great! I don't have ability to change maintainers but as far as I'm concerned it would be great to see this project have a new life with D8. I've put in a word with one of the primary maintainers to get you access. Couple questions:
7.x-1.x. I just want to create the8.x-1.xbranch properly.Comment #3
id.tornado CreditAttribution: id.tornado commentedThanks
Comment #4
ruplCool! I wanted to do a little bit of cleanup in addition to opening the 8.x-1.x branch for ya, but the patch produced some errors. I definitely want you to maintain NineSixty, but since you don't have any existing commits I could look at one your d.o profile could you clean up this patch as a demonstration of your awesome maintainer skills? ;)
I've set the issue to "Needs work" while you fix up the patch. Once you have a new patch up set the issue to "Needs Review" and it'll surface more quickly in my dashboard for review. Here's the full workflow for Drupal.org issue queue: https://drupal.org/node/156119
PS I'm not entirely sure what the errors mean but I found this. If you still have the files around could you give it a try?
http://stackoverflow.com/questions/17152171/git-cannot-apply-binary-patc...
Comment #5
id.tornado CreditAttribution: id.tornado commentedSeems like this patch applied without errors.
Comment #6
ruplThanks for re-rolling the patch! #5 worked great. Thank you for your contribution!
I have committed it to 8.x-1.x branch. I sincerely apologize but I forgot to credit you as the author before pushing the code. This is something I'm normally really good about, and this was a significant patch so I'm very sorry about that :(
On the plus side, you have been added as a maintainer to Ninesixty! You can can freely commit new code, manage issues, and all the wonderful tasks that maintainers can do! The only thing you won't be able to do is manage the maintainers themselves.