After upgrading to the latest stable icon module (7.x-1.0-beta5), installing fresh Drupal (latest stable core, 7.26) with icon module in a custom install profile (using "dependencies[] = icon" in myprofile.info) results in the install hanging and PHP eating all available CPU / memory.
I narrowed it down, and it's hanging on the "menu_rebuild()" call in theme_enable(), which I call from a myprofile_install() hook implementation.
So, I suspect that the culprit is the recent changes to icon_menu() from #2075259: Add "view icons" permission and path alias for viewing icons (although that's just my guess, didn't see anything in the icon_menu() changes particularly bad-looking).
Enabling the icon module after site install works fine - just enabling it via install profile dependencies is problematic. Worked fine before I upgraded icon module to beta5 today. If I comment out "dependencies[] = icon" in myprofile.info, site installs fine.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | icon-menu_item_loop-2200087-4.patch | 2.39 KB | plach |
Comments
Comment #1
blackice2999 commentedSame issue here. I attached a patch that currently solves this problem. The problem is on first run there is no menu build on drupal so the menu router items are empty. In this case menu_get_item will try to rebuild the menu so we run here into a menu rebuild loop.
The attached patch simple removes the menu_get_item because i see no reason why it will be needed here?!
Comment #2
blackice2999 commentedComment #3
drupov commentedWow, thanks! It took me forever to figure out that the icon module was causing the infinite loop in my profile.
Confirming that the patch from #1 works.
Comment #4
plach@markcarver in IRC asked for something not skipping the menu item check.
Comment #5
markhalliwellThanks @plach!
Committed 848b9d9 to 7.x-1.x: