Closed (duplicate)
Project:
ImageCache Actions
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2014 at 15:32 UTC
Updated:
10 Apr 2014 at 20:04 UTC
Jump to comment: Most recent
Comments
Comment #1
deimos commentedComment #2
fietserwinThat would be great.
We certainly want to port this module to D8. However, the current state of the image system is not such that we can already start. Main things lacking for us are an alternative for image_toolkit_invoke() to give our toolkit specific code a place and access to save options for our change file format effect.
A first way of helping would be to contribute to the images system and image module issues in the Drupal core queue. yo can help by reviewing, taking part in technical discussions, writing patches and testing, whether manually, or by writing tests. (@dman, perhaps you are able to review #2168511: Allow to pass save options to ImageInterface::save, as that is really going to block us for the format conversion effect?)
Most important issues for this module:
- #2105863: [meta] Images, toolkits and operations and its child issues
- #2168511: Allow to pass save options to ImageInterface::save
- #2103621: Move GD logic from ImageInterface to toolkit, tie toolkit instance to Image instance, toolkits should no longer be instantiated separately
- #2196067: Remove setWidth and setHeight from ImageInterface
- #2098247: Provide a hook for ImageStyle::createDerivative
- #2110835: Move the GD toolkit on its own module
OTOH, A lot can already be done. We could start by either creating a sandbox or a D8 branch in this project. I think that we should go for 1 module for all effects and renaming that single module to image_effects. Shared code can be put in a class hierarchy or helper/utility classes. E.g. a standard form field for color would be better off in a form helper than in a base color actions class (old name of module).
Comment #3
dman commentedYep.
Ws talking with some folk at DrupalSouth and the core code sprint this week.
I don't personally feel confident with D8 yet, but I'm seeing the roadmap.
Yes, now that all the effects can be their own plugins, we get to remove the arbitrary grouping that was the submodules.
Comment #4
fietserwinClosing as duplicate of #2228361: Drupal 8 port as there is a patch over there.