In #1813200: Validation of field type number fails for decimal separator, we corrected handling of non-period decimal place holders, but at the same time we broke handling of negative numbers. When any negative number is entered, this validation error is thrown on submit: @name field value must format numbers as "12,345.68".

We actually have automated tests for this, but they weren't run before the release. I've enabled automated testing on the Webform project, so hopefully we can avoid these regressions in the future.

CommentFileSizeAuthor
webform_number_negative.patch1.35 KBquicksketch

Comments

quicksketch’s picture

Status: Active » Needs review
quicksketch’s picture

Status: Needs review » Fixed

Committed this to all branches of the project.

Status: Fixed » Needs work

The last submitted patch, webform_number_negative.patch, failed testing.

quicksketch’s picture

Status: Needs work » Fixed

Thanks for testing this 5 days later testbot. :P Moving back to fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

fenstrat’s picture

Version: 7.x-4.x-dev » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Closed (fixed) » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

Version: 8.x-4.x-dev » 7.x-4.x-dev
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed 321c088 to 8.x-4.x. Thanks!

  • Commit dd781a3 on 8.x-4.x authored by quicksketch, committed by fenstrat:
    Issue #2198007 by quicksketch: Negative numbers always fail validation.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.