Closed (fixed)
Project:
Signup
Version:
5.x-2.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
9 Feb 2008 at 15:48 UTC
Updated:
23 Aug 2008 at 11:03 UTC
Jump to comment: Most recent file
When a user signs up, the node owner is told his email address. Drupal states on the user profile that your email address will not be shared. I propose to make this a global setting that defaults to off. Or make this email configurable so it can be removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 219680_signup_no_email_disclose.head_.patch | 1.23 KB | dww |
Comments
Comment #1
csc4 commentedSubscribing - sounds like an excellent idea
Comment #2
Andrius Kurtinaitis commentedStrictly speaking, I agree that the issue is correct. I just think that the disclosure of user email is implicitly expected from both user and the node owner. This is just useful feature of the signup module. Otherwise it would not be that useful...
A module that works as expected by default is better than one that has clever settings that allow to unbreak it.
The other thing is about drupal policy. It is not an argument because Signup is not a core module. And as such does not have to follow all the texts of core.
Another idea - maybe the module could show the emails to the owners that anyway have the right to see peoples emails?
Comment #3
dwwMoshe, can you clarify what you're talking about? You mean the text of the email notification sent to the event owner? Otherwise, all the signup info is pretty well protected by the existing permissions, no?
Comment #4
moshe weitzman commentedI don't really recall - i guess that i meant either the from email or the body of the email.
Comment #5
dwwOk, it's in the body of the email -- I see that much, and I agree that's not ideal (except in cases of anonymous signups, where that's all we know about them). It should really just be a link to their account page or something (although it's complicated by the fact that these emails can be sent anywhere the event author wants, including to people who don't have perms to view user profile pages, etc). I guess a link to an "access denied" page is better than info disclosure right in the body of the email.
Anyway, I'll figure something out and get this in before the 5.x-2.5 release -- this *is* a real bug.
Comment #6
dwwSo, what's the right way to fix this?
A) Change the hard-coded body of the email to include a link to the profile page instead of an email address?
B) Make the format of this email message a site-wide signup setting, and use tokens? (See also #285626: Integration with the Token module).
Thoughts?
Comment #7
dwwThe more I think about this, the more I think admins should be able to lock down this feature. See #118794: Using Event author for "send signups to" address for more about that.
Meanwhile, here's a quick/dirty patch to print a link to the user's profile page if they've got an account, and their email if they're anon (since that's all we've got). Untested.
Comment #8
duellj commentedTested. Thanks dww.
Comment #9
dwwCommitted to HEAD and backported to DRUAPL-5. If anyone can test 5.x-1.x-dev, that'd be swell. ;) Thanks.
Comment #10
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.