When tab-selecting the elements in a table, the table drag widget renders the grippie as white on white.

This happens with the Stark, Seven and Bartik themes.

See attached screenshot.

CommentFileSizeAuthor
#1 drupal-grippie-focus-2195959-1.patch2.15 KBlewisnyman
Selection_001.png5.06 KBquietone

Comments

lewisnyman’s picture

lewisnyman
he/him
commented
Component: Seven theme » system.module
Issue tags: +Accessibility
StatusFileSize
new drupal-grippie-focus-2195959-1.patch2.15 KB

This looks like a global problem with tabledrag which was unintentionally introduced a while back. This patch fixes the problem on hover and focus.

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Active » Needs review
mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +CSS

This looks great and it works way better.

I'd like someone else to look over the CSS, but from an accessibility & usability point of view this is way better.

It was pretty annoying to see that + symbol just disappear. It was the worst for keyboard only users where on focus it just disappeared.

Thanks for catching this!

EDIT: This is easy to test on SimplyTest.me by going to /admin/config/content/formats

tompagabor’s picture

tompagabor commented

Looks good +1 to RTBC.

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

We tried to make it mobile friendly, small bug :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Tab-select renders grippie white one white » Tab-select renders grippie white on white
Status: Reviewed & tested by the community » Fixed

Committed e74db80 and pushed to 8.x. Thanks!

  • Commit e74db80 on 8.x by alexpott: 
    Issue #2195959 by LewisNyman: Tab-select renders grippie white on white.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.