"Back to site" button doesn't work when the user originates from the homepage. [#2195933]

I'm not 100% sure but I think #2194763: 'back to site' button doesn't work on site configured for 'dirty' url's is a duplicate of this. Can you give more info on what error you actually saw? Steps on how to reproduce would help.

Log in or register to post comments

Comment #4

sam152 commented 14 February 2014 at 23:44

This is an entirely different issue. This isn't related to clean URLs or accessing index.php directly. Basically any time you leave the main website and venture into the admin panel, the state is saved so you can click "Back to site". Since the homepage is stored as an empty string, when the code included in the patch includes if (escapeAdminPath) it prevents the button from appearing because empty strings are falsey in JavaScript.

Since sessionStorage.getItem returns null for values that don't exist, we can safely update the condition to be more strict in it's checking.

Log in or register to post comments

Comment #5

dman commented 15 February 2014 at 11:41

Yeah, the problem definition here, succinctly described as :

Proposed resolution
Fix the problem.

Is hard to treat as an actionable "bug"

Needs:
much more clear functional, testable steps to reproduce
a description of the fail state and the expected success state.

Anything else cannot be evaluated without a huge number of unstated assumptions.

Log in or register to post comments

Comment #6

sam152 commented 15 February 2014 at 12:06

Issue summary:

View changes

Log in or register to post comments

Comment #7

sam152 commented 15 February 2014 at 12:07

Issue summary:

View changes

Log in or register to post comments

Comment #8

sam152 commented 15 February 2014 at 12:10

Dman, thanks for the review of the issue summary. First time using the template, the "Proposed resolution" section seemed somewhat superfluous.

I have updated the issue with some more information to hopefully make this issue easier to follow.

Log in or register to post comments

Comment #9

dcrocks commented 15 February 2014 at 19:03

Tried to reproduce. When I run without clean url's, this doesn't happen. When I run with clean url's, this doesn't happen the 1st time I click on a toolbar admin tab, but does happen every time afterward. The process:

0. I'm running on OS X 10.6.
1. Clone a current dev copy of D8 into %username/Sites directory.
2. Modify .htaccess to turn on 'RewriteBase /~%username/drupal8'.
3. Run D8 install.
4. Sign in to drupal8. Toolbar is displayed at top of page.
5. Click on 'Content' tab and 'Back to site' button displayed.
6. Click on 'home'
7. Click on 'Content' tab again and 'Back to site button' is NOT displayed.
8. Repeat #6 and #7 n* times, with any any toolbar tab, and result always same, no 'Back to site' button.

Sign in and sign out and the behavior repeats.

Log in or register to post comments

Comment #10

dman commented 15 February 2014 at 20:35

Issue summary:

View changes

Yeah I'm seeing this too. Can replicate.
This is indeed unexpected and a UI WTF.

I can confirm that this patch fixes it. as expected.
The code is a good fix.

Log in or register to post comments

Comment #11

dman commented 18 February 2014 at 04:39

Status:

Needs review

» Reviewed & tested by the community

I was going to RTBC this when I reviewed, but was in a hurry so stepped back to consider if there was anything I hadn't thought of. Seeing as nothing has come to mind since then, I do vote this as good to go.