Clean up configuration import events

ConfigImporter::ID was used to disambiguate installation and importing when they both used the ConfigImporter. This no longer occurs so lets clean that up here too.

+++ b/core/lib/Drupal/Core/Config/ConfigImporter.php
@@ -227,7 +229,7 @@ public function validate() {
+      $this->eventDispatcher->dispatch(ConfigEvents::VALIDATE, new ConfigImporterEvent($this));

@beejeebus pointed out that VALIDATE could be confused with the CRUD events. Let's also rename this to IMPORT_VALIDATE

Yeah naming the events even better +1 :) Thanks Sutharsan for working on this :)

1. +++ b/core/lib/Drupal/Core/Config/ConfigImporter.php
   @@ -32,9 +33,9 @@
   -  const ID = 'config.importer';
   +  const LOCKID = 'config_importer';
   

   Convention is an underscore between words in class constants. So LOCK_ID

2. +++ b/core/lib/Drupal/Core/Config/ConfigImporter.php
   @@ -294,33 +296,23 @@ protected function importInvokeOwner() {
   +  public function getLockId() {
   +    return static::LOCKID;
      }
   
   +++ b/core/modules/config/lib/Drupal/config/Tests/ConfigImportUITest.php
   @@ -101,7 +101,7 @@ function testImportLock() {
   -    $config_importer_lock = $this->configImporter()->getId();
   +    $config_importer_lock = $this->configImporter()->getLockId();
        $this->container->get('lock')->acquire($config_importer_lock);
   

   Lets remove getLockId() too and just use ConfigImporter::LOCK_ID

Looks good.

config-import-events-2195417-12.patch no longer applies.

error: patch failed: core/lib/Drupal/Core/Config/ConfigImporter.php:7
error: core/lib/Drupal/Core/Config/ConfigImporter.php: patch does not apply

Back to RTBC.

Crossposting #1889474: Create tests for config event handling, that's an old major that I think is obsolete?

@tim.plunkett: thanks, closed that down as duplicate of #2175917: Clean up configuration system events where tests were added :)

This cleanup looks good :)

Committed 65899f6 and pushed to 8.x. Thanks!