In D7, if you click the "edit shortcuts" link on your Shortcuts bar, it takes you to the list of shortcut links, which seems very logical to me.

In D8, if you click the "edit shortcuts" link, you are instead taken to the tab where you can edit the name of the shortcut set, which is very unlikely to be what you wanted (really, how often would you want to do that? when you see a list of shortcuts and click "edit", wouldn't you logically want to modify the links in some way?).

So I think this is a UI regression bug. Can you switch it back?

CommentFileSizeAuthor
#5 drupal-edit-shortcut-redirect-2194563-5.patch669 bytesanksy
#2 drupal-edit-shortcut-redirect-2194563-1.patch646 bytesanksy

Comments

anksy’s picture

anksy commented
Status: Active » Needs review
anksy’s picture

anksy commented
StatusFileSize
new drupal-edit-shortcut-redirect-2194563-1.patch646 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Wow, this code should be using a route and not a direct HREF.

anksy’s picture

anksy commented

It was already using an HREF I just switched it back to the drupal 7 version.
So can you suggest how do I implement URL routing here??

anksy’s picture

anksy commented
StatusFileSize
new drupal-edit-shortcut-redirect-2194563-5.patch669 bytes

This patch uses route instead of a direct HREF.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I just tested this patch and it works fine. Good job! I think I'll go ahead and mark it RTBC, although we might want to wait before committing it in case the shortcut module maintainers want to argue that it should not work this way.

Oh, I guess there aren't any maintainers listed in MAINTAINERS.txt for this module. :(

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: drupal-edit-shortcut-redirect-2194563-5.patch, failed testing.

anksy’s picture

anksy commented
Status: Needs work » Needs review

5: drupal-edit-shortcut-redirect-2194563-5.patch queued for re-testing.

anksy’s picture

anksy commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oh, yes please. This makes WAY more sense.

Committed and pushed to 8.x. Thanks!

  • Commit 8eca2cd on 8.x by webchick: 
    Issue #2194563 by anksy, jhodgdon: Edit link on Shortcuts should go to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.