Closed (fixed)
Project:
radix
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Feb 2014 at 10:31 UTC
Updated:
7 Nov 2021 at 13:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dsnopekI've seen this too when running Radix directly, not in any sub-theme. But I might have done something wrong - I didn't have time to look into it. Anyway, when we add Radix to Panopoly, we might default to having Radix un-sub-themed as the default.
Comment #2
shadcn commentedI pushed a fix for that. Let me know if this works.
Comment #3
lsolesen commentedI think you pushed on the 3.x-branch. I am working on the 2.x-branch right now :)
Comment #4
lsolesen commentedAdding patch which simply removes the logic until this is fixed.
Comment #5
lsolesen commentedComment #6
shadcn commentedBackported the fix from 7.x-3.x to 2.x. This should be ok now.
Comment #8
mpotter commentedThis un-does the patch from #2188883: Proper placeholders for Sass compiling message to fix the placeholder values. Was that intended?
Comment #9
shadcn commentedFixed. Thanks Mike.
Comment #11
dsnopekI'm actually still seeing this. :-/ If I create a sub-theme of a Radix sub-theme, then I get this error - however, I don't plan to ever create a screen.css for my sub-sub-theme!
For example, if I create a sub-theme of oa_radix, I don't want to generate my own screen.css because it'll override oa_radix's screen.css. I'll create css files with different names to layer on top of oa_radix's screen.css.
I've attached a patch which will only check for screen.css if the current theme is a direct sub-theme of radix, which fixes the problem for me!
Comment #12
shadcn commentedRadix Kit is on the way with support for your own custom subtheme. http://arshad.github.io/radix-docs/Kits.html :)
This should fix the issue we have here.
Comment #13
ckoppenhaver commentedThe patch that dsnopek created was not working for the 3.x branch so I took the work he did and created another patch for 3.x.
Comment #14
dsnopek@ckoppenhaver's patch fixes this for me with Radix 3! Thanks!
Comment #15
dsnopekEr, and updating version too.
Comment #16
shadcn commentedSince we're on this topic, I'd like to pick your brain on this one too #2363785: radix_preprocess_page() is too strick about css preprocessor been used and directory structure.
Comment #17
dsnopekThe code that emits this warning has been commented out in Radix 3.x! So, moving to 7.x-2.x-dev where the code still exists. Although, it's probably better to use the same fix in 2.x (ie. comment out this code) rather than this patch.
Comment #18
doxigo commented7 years late to the party, removed the code from
7.x-2.xjust to get all the RTBC issues closedComment #19
doxigo commentedComment #20
doxigo commented