I've created a subtheme of Chef. If I create a screen.css in my subtheme, Chef's screen.css is will not be used. But if I do not create a screen.css in my subtheme, I get the following:

It looks like sites/vies.dk/themes/ketsjup/assets/stylesheets/screen.css has not been created yet. Run compass watch in your theme directory to create it.

Comments

dsnopek’s picture

I've seen this too when running Radix directly, not in any sub-theme. But I might have done something wrong - I didn't have time to look into it. Anyway, when we add Radix to Panopoly, we might default to having Radix un-sub-themed as the default.

shadcn’s picture

Status: Active » Needs review

I pushed a fix for that. Let me know if this works.

lsolesen’s picture

I think you pushed on the 3.x-branch. I am working on the 2.x-branch right now :)

lsolesen’s picture

StatusFileSize
new1.43 KB

Adding patch which simply removes the logic until this is fixed.

lsolesen’s picture

StatusFileSize
new713 bytes
shadcn’s picture

Status: Needs review » Fixed

Backported the fix from 7.x-3.x to 2.x. This should be ok now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mpotter’s picture

Status: Closed (fixed) » Active

This un-does the patch from #2188883: Proper placeholders for Sass compiling message to fix the placeholder values. Was that intended?

shadcn’s picture

Status: Active » Fixed

Fixed. Thanks Mike.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dsnopek’s picture

Title: Error when screen.css is not created » Error when screen.css is not created (in sub-sub-theme)
Version: 7.x-2.0 » 7.x-2.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new1.92 KB

I'm actually still seeing this. :-/ If I create a sub-theme of a Radix sub-theme, then I get this error - however, I don't plan to ever create a screen.css for my sub-sub-theme!

For example, if I create a sub-theme of oa_radix, I don't want to generate my own screen.css because it'll override oa_radix's screen.css. I'll create css files with different names to layer on top of oa_radix's screen.css.

I've attached a patch which will only check for screen.css if the current theme is a direct sub-theme of radix, which fixes the problem for me!

shadcn’s picture

Radix Kit is on the way with support for your own custom subtheme. http://arshad.github.io/radix-docs/Kits.html :)

This should fix the issue we have here.

ckoppenhaver’s picture

StatusFileSize
new1.59 KB

The patch that dsnopek created was not working for the 3.x branch so I took the work he did and created another patch for 3.x.

dsnopek’s picture

Status: Needs review » Reviewed & tested by the community

@ckoppenhaver's patch fixes this for me with Radix 3! Thanks!

dsnopek’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev

Er, and updating version too.

shadcn’s picture

Since we're on this topic, I'd like to pick your brain on this one too #2363785: radix_preprocess_page() is too strick about css preprocessor been used and directory structure.

dsnopek’s picture

Version: 7.x-3.x-dev » 7.x-2.x-dev

The code that emits this warning has been commented out in Radix 3.x! So, moving to 7.x-2.x-dev where the code still exists. Although, it's probably better to use the same fix in 2.x (ie. comment out this code) rather than this patch.

doxigo’s picture

7 years late to the party, removed the code from 7.x-2.x just to get all the RTBC issues closed

doxigo’s picture

doxigo’s picture

Status: Reviewed & tested by the community » Fixed

  • doxigo committed 9603211 on 7.x-2.x authored by ckoppenhaver
    Issue #2194335 by lsolesen, dsnopek, ckoppenhaver, shadcn, mpotter,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.